Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: src/base/platform/platform.h

Issue 1111733002: [clang] Use -Wshorten-64-to-32 to enable warnings about 64bit to 32bit truncations. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix Win warnings. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « samples/shell.cc ('k') | src/base/platform/platform-aix.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/base/platform/platform.h
diff --git a/src/base/platform/platform.h b/src/base/platform/platform.h
index 1873bbe57d7bb96bcb31b2fe044b298ba9882de3..2d837baff61078fedd74626491dc28db8d3bf930 100644
--- a/src/base/platform/platform.h
+++ b/src/base/platform/platform.h
@@ -210,11 +210,13 @@ class OS {
class MemoryMappedFile {
public:
+ virtual ~MemoryMappedFile() {}
+ virtual void* memory() const = 0;
+ virtual size_t size() const = 0;
+
static MemoryMappedFile* open(const char* name);
- static MemoryMappedFile* create(const char* name, int size, void* initial);
- virtual ~MemoryMappedFile() { }
- virtual void* memory() = 0;
- virtual int size() = 0;
+ static MemoryMappedFile* create(const char* name, size_t size,
+ void* initial);
};
// Safe formatting print. Ensures that str is always null-terminated.
« no previous file with comments | « samples/shell.cc ('k') | src/base/platform/platform-aix.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698