Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Side by Side Diff: build/standalone.gypi

Issue 1111733002: [clang] Use -Wshorten-64-to-32 to enable warnings about 64bit to 32bit truncations. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix Win warnings. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | samples/process.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2012 the V8 project authors. All rights reserved. 1 # Copyright 2012 the V8 project authors. All rights reserved.
2 # Redistribution and use in source and binary forms, with or without 2 # Redistribution and use in source and binary forms, with or without
3 # modification, are permitted provided that the following conditions are 3 # modification, are permitted provided that the following conditions are
4 # met: 4 # met:
5 # 5 #
6 # * Redistributions of source code must retain the above copyright 6 # * Redistributions of source code must retain the above copyright
7 # notice, this list of conditions and the following disclaimer. 7 # notice, this list of conditions and the following disclaimer.
8 # * Redistributions in binary form must reproduce the above 8 # * Redistributions in binary form must reproduce the above
9 # copyright notice, this list of conditions and the following 9 # copyright notice, this list of conditions and the following
10 # disclaimer in the documentation and/or other materials provided 10 # disclaimer in the documentation and/or other materials provided
(...skipping 225 matching lines...) Expand 10 before | Expand all | Expand 10 after
236 ], 236 ],
237 'conditions': [ 237 'conditions': [
238 ['os_posix == 1 and OS != "mac"', { 238 ['os_posix == 1 and OS != "mac"', {
239 # We don't want to get warnings from third-party code, 239 # We don't want to get warnings from third-party code,
240 # so remove any existing warning-enabling flags like -Wall. 240 # so remove any existing warning-enabling flags like -Wall.
241 'cflags!': [ 241 'cflags!': [
242 '-pedantic', 242 '-pedantic',
243 '-Wall', 243 '-Wall',
244 '-Werror', 244 '-Werror',
245 '-Wextra', 245 '-Wextra',
246 '-Wshorten-64-to-32',
246 ], 247 ],
247 'cflags+': [ 248 'cflags+': [
248 # Clang considers the `register` keyword as deprecated, but 249 # Clang considers the `register` keyword as deprecated, but
249 # ICU uses it all over the place. 250 # ICU uses it all over the place.
250 '-Wno-deprecated-register', 251 '-Wno-deprecated-register',
251 # ICU uses its own deprecated functions. 252 # ICU uses its own deprecated functions.
252 '-Wno-deprecated-declarations', 253 '-Wno-deprecated-declarations',
253 # ICU prefers `a && b || c` over `(a && b) || c`. 254 # ICU prefers `a && b || c` over `(a && b) || c`.
254 '-Wno-logical-op-parentheses', 255 '-Wno-logical-op-parentheses',
255 # ICU has some `unsigned < 0` checks. 256 # ICU has some `unsigned < 0` checks.
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
382 '-Wno-long-long', 383 '-Wno-long-long',
383 '-pthread', 384 '-pthread',
384 '-fno-exceptions', 385 '-fno-exceptions',
385 '-pedantic', 386 '-pedantic',
386 # Don't warn about the "struct foo f = {0};" initialization pattern. 387 # Don't warn about the "struct foo f = {0};" initialization pattern.
387 '-Wno-missing-field-initializers', 388 '-Wno-missing-field-initializers',
388 ], 389 ],
389 'cflags_cc': [ '-Wnon-virtual-dtor', '-fno-rtti', '-std=gnu++0x' ], 390 'cflags_cc': [ '-Wnon-virtual-dtor', '-fno-rtti', '-std=gnu++0x' ],
390 'ldflags': [ '-pthread', ], 391 'ldflags': [ '-pthread', ],
391 'conditions': [ 392 'conditions': [
393 # TODO(arm64): It'd be nice to enable this for arm64 as well,
394 # but the Assembler requires some serious fixing first.
395 [ 'clang==1 and v8_target_arch=="x64"', {
396 'cflags': [ '-Wshorten-64-to-32' ],
397 }],
392 [ 'host_arch=="ppc64" and OS!="aix"', { 398 [ 'host_arch=="ppc64" and OS!="aix"', {
393 'cflags': [ '-mminimal-toc' ], 399 'cflags': [ '-mminimal-toc' ],
394 }], 400 }],
395 [ 'visibility=="hidden" and v8_enable_backtrace==0', { 401 [ 'visibility=="hidden" and v8_enable_backtrace==0', {
396 'cflags': [ '-fvisibility=hidden' ], 402 'cflags': [ '-fvisibility=hidden' ],
397 }], 403 }],
398 [ 'component=="shared_library"', { 404 [ 'component=="shared_library"', {
399 'cflags': [ '-fPIC', ], 405 'cflags': [ '-fPIC', ],
400 }], 406 }],
401 ], 407 ],
(...skipping 228 matching lines...) Expand 10 before | Expand all | Expand 10 after
630 ['use_goma==1 and ("<(GENERATOR)"=="ninja" or clang==1)', { 636 ['use_goma==1 and ("<(GENERATOR)"=="ninja" or clang==1)', {
631 'make_global_settings': [ 637 'make_global_settings': [
632 ['CC_wrapper', '<(gomadir)/gomacc'], 638 ['CC_wrapper', '<(gomadir)/gomacc'],
633 ['CXX_wrapper', '<(gomadir)/gomacc'], 639 ['CXX_wrapper', '<(gomadir)/gomacc'],
634 ['CC.host_wrapper', '<(gomadir)/gomacc'], 640 ['CC.host_wrapper', '<(gomadir)/gomacc'],
635 ['CXX.host_wrapper', '<(gomadir)/gomacc'], 641 ['CXX.host_wrapper', '<(gomadir)/gomacc'],
636 ], 642 ],
637 }], 643 }],
638 ], 644 ],
639 } 645 }
OLDNEW
« no previous file with comments | « no previous file | samples/process.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698