Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 1111713002: CacheStorage: [Retry] Merge CacheStorageListener into CacheStorageDispatcherHost (1) (Closed)

Created:
5 years, 8 months ago by nhiroki
Modified:
5 years, 8 months ago
Reviewers:
falken
CC:
chromium-reviews, darin-cc_chromium.org, jam, jkarlin+watch_chromium.org, jsbell
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CacheStorage: [Retry] Merge CacheStorageListener into CacheStorageDispatcherHost (1) Original: https://codereview.chromium.org/1101733005/ CacheStorageListener and CacheStorageDispatcher are now in a 1:1 relationship and the indirection is no longer necessary. As a first step of merge, this CL moves message handlers for CacheStorage API from the listener to the dispatcher. BUG=474233 TEST=content_unittests --gtest_filter=CacheStorage* TEST=run-webkit-tests http/tests/cachestorage/ Committed: https://crrev.com/e53df5f78de6faa359d5f72746f21213731c7fc0 Cr-Commit-Position: refs/heads/master@{#327242}

Patch Set 1 : Original (https://codereview.chromium.org/1101733005/) #

Patch Set 2 : Fix layouttest failures #

Unified diffs Side-by-side diffs Delta from patch set Stats (+280 lines, -236 lines) Patch
M content/browser/cache_storage/cache_storage_dispatcher_host.h View 2 chunks +46 lines, -0 lines 0 comments Download
M content/browser/cache_storage/cache_storage_dispatcher_host.cc View 1 4 chunks +229 lines, -1 line 0 comments Download
M content/browser/cache_storage/cache_storage_listener.h View 3 chunks +2 lines, -44 lines 0 comments Download
M content/browser/cache_storage/cache_storage_listener.cc View 4 chunks +3 lines, -191 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
nhiroki
Hi falken@, can you take a look at this? (especially diff between the patchset1 and ...
5 years, 8 months ago (2015-04-28 06:19:31 UTC) #2
falken
lgtm
5 years, 8 months ago (2015-04-28 06:29:56 UTC) #3
nhiroki
On 2015/04/28 06:29:56, falken wrote: > lgtm Thank you!
5 years, 8 months ago (2015-04-28 06:40:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111713002/20001
5 years, 8 months ago (2015-04-28 06:40:56 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-28 07:17:19 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-28 07:18:17 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e53df5f78de6faa359d5f72746f21213731c7fc0
Cr-Commit-Position: refs/heads/master@{#327242}

Powered by Google App Engine
This is Rietveld 408576698