Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 1111703002: Revert of CacheStorage: Merge CacheStorageListener into CacheStorageDispatcherHost (1) (Closed)

Created:
5 years, 7 months ago by pdr.
Modified:
5 years, 7 months ago
Reviewers:
jsbell, nhiroki
CC:
chromium-reviews, darin-cc_chromium.org, jam, jkarlin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of CacheStorage: Merge CacheStorageListener into CacheStorageDispatcherHost (1) (patchset #2 id:140001 of https://codereview.chromium.org/1101733005/) Reason for revert: I think this patch caused layouttest failures on the Blink tree, see crbug.com/481784 for details. Original issue's description: > CacheStorage: Merge CacheStorageListener into CacheStorageDispatcherHost (1) > > CacheStorageListener and CacheStorageDispatcher are now in a 1:1 relationship > and the indirection is no longer necessary. As a first step of merge, this CL > moves message handlers for CacheStorage API from the listener to the dispatcher. > > BUG=474233 > TEST=content_unittests --gtest_filter=CacheStorage* > > Committed: https://crrev.com/34cbfce4cae255c11fb19059ea4a31166768cdcf > Cr-Commit-Position: refs/heads/master@{#327199} TBR=jsbell@chromium.org,nhiroki@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=474233, 481784 Committed: https://crrev.com/529b2d0c6a109b6bd5f359832245b64fccab32f7 Cr-Commit-Position: refs/heads/master@{#327229}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -280 lines) Patch
M content/browser/cache_storage/cache_storage_dispatcher_host.h View 2 chunks +0 lines, -46 lines 0 comments Download
M content/browser/cache_storage/cache_storage_dispatcher_host.cc View 3 chunks +1 line, -229 lines 0 comments Download
M content/browser/cache_storage/cache_storage_listener.h View 2 chunks +44 lines, -2 lines 0 comments Download
M content/browser/cache_storage/cache_storage_listener.cc View 4 chunks +191 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
pdr.
Created Revert of CacheStorage: Merge CacheStorageListener into CacheStorageDispatcherHost (1)
5 years, 7 months ago (2015-04-28 04:00:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111703002/1
5 years, 7 months ago (2015-04-28 04:01:34 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-28 04:02:05 UTC) #4
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 04:02:52 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/529b2d0c6a109b6bd5f359832245b64fccab32f7
Cr-Commit-Position: refs/heads/master@{#327229}

Powered by Google App Engine
This is Rietveld 408576698