Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Unified Diff: lib/html/scripts/systemhtml.py

Issue 11117025: Remove ParamInfo.dart_type field. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/html/scripts/generator.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/html/scripts/systemhtml.py
diff --git a/lib/html/scripts/systemhtml.py b/lib/html/scripts/systemhtml.py
index f225fa681c25bcb948b9518d85ae1396821d4078..a163caf907e209e99f4b5dc687839521526601d0 100644
--- a/lib/html/scripts/systemhtml.py
+++ b/lib/html/scripts/systemhtml.py
@@ -82,7 +82,7 @@ class ElementConstructorInfo(object):
info.constructor_name = self.name
info.js_name = None
info.type_name = interface_name
- info.param_infos = map(lambda tXn: ParamInfo(tXn[1], None, tXn[0], 'null'),
+ info.param_infos = map(lambda tXn: ParamInfo(tXn[1], tXn[0], 'null'),
self.opt_params)
return info
@@ -866,7 +866,7 @@ class Dart2JSBackend(object):
if conversion:
return conversion.input_type
else:
- return self._NarrowInputType(type_name)
+ return self._NarrowInputType(type_name) if type_name else 'Dynamic'
body = self._members_emitter.Emit(
'\n'
@@ -879,7 +879,7 @@ class Dart2JSBackend(object):
PARAMS=info.ParametersImplementationDeclaration(InputType))
parameter_names = [param_info.name for param_info in info.param_infos]
- parameter_types = [InputType(param_info.dart_type)
+ parameter_types = [InputType(param_info.type_id)
for param_info in info.param_infos]
operations = info.operations
@@ -920,7 +920,7 @@ class Dart2JSBackend(object):
arguments.append(parameter_names[position])
param_type = self._NarrowInputType(arg.type.id)
# Verified by argument checking on entry to the dispatcher.
- verified_type = InputType(info.param_infos[position].dart_type)
+ verified_type = InputType(info.param_infos[position].type_id)
# The native method does not need an argument type if we know the type.
# But we do need the native methods to have correct function types, so
@@ -1027,8 +1027,6 @@ class Dart2JSBackend(object):
return False
def _NarrowToImplementationType(self, type_name):
- if type_name == 'Dynamic':
- return type_name
return self._type_registry.TypeInfo(type_name).narrow_dart_type()
def _NarrowInputType(self, type_name):
« no previous file with comments | « lib/html/scripts/generator.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698