Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 11117012: ash: Fix event processing in modal windows in login/lock screen. (Closed)

Created:
8 years, 2 months ago by sadrul
Modified:
8 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

ash: Fix event processing in modal windows in login/lock screen. The RootWindowController would always use the default modal-container. However, in the login screen or the lockscreen, the special lock-screen modal container needs to be used. BUG=154607 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=161632

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -15 lines) Patch
M ash/root_window_controller.h View 1 chunk +9 lines, -1 line 0 comments Download
M ash/root_window_controller.cc View 2 chunks +19 lines, -2 lines 2 comments Download
M ash/root_window_controller_unittest.cc View 2 chunks +25 lines, -0 lines 0 comments Download
M ash/shell.cc View 5 chunks +12 lines, -9 lines 0 comments Download
M ash/system/status_area_widget.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/wm/shelf_layout_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/wm/system_modal_container_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
sadrul
The CL also includes some missing null-checks for status_area_widget.
8 years, 2 months ago (2012-10-12 06:27:27 UTC) #1
sky
LGTM http://codereview.chromium.org/11117012/diff/1/ash/root_window_controller.cc File ash/root_window_controller.cc (right): http://codereview.chromium.org/11117012/diff/1/ash/root_window_controller.cc#newcode182 ash/root_window_controller.cc:182: Shell::GetInstance()->tray_delegate()->GetUserLoginStatus() : nit: indent 4 for 182/183. How ...
8 years, 2 months ago (2012-10-12 17:00:37 UTC) #2
sadrul
8 years, 2 months ago (2012-10-12 18:24:30 UTC) #3
http://codereview.chromium.org/11117012/diff/1/ash/root_window_controller.cc
File ash/root_window_controller.cc (right):

http://codereview.chromium.org/11117012/diff/1/ash/root_window_controller.cc#...
ash/root_window_controller.cc:182:
Shell::GetInstance()->tray_delegate()->GetUserLoginStatus() :
On 2012/10/12 17:00:37, sky wrote:
> nit: indent 4 for 182/183.
> How come we have user login status on the TrayDelegate and similar type
methods
> on ShellDelegate? Can they be unified? It can be done separately though.

Agree. Filed http://code.google.com/p/chromium/issues/detail?id=155573

Powered by Google App Engine
This is Rietveld 408576698