Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: Source/platform/WebThreadSupportingGC.h

Issue 1111693003: Remove the concept of a cleanup task (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: ASSERT => ASSERT_UNUSED Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WebThreadSupportingGC_h 5 #ifndef WebThreadSupportingGC_h
6 #define WebThreadSupportingGC_h 6 #define WebThreadSupportingGC_h
7 7
8 #include "platform/heap/glue/MessageLoopInterruptor.h" 8 #include "platform/heap/glue/MessageLoopInterruptor.h"
9 #include "platform/heap/glue/PendingGCRunner.h" 9 #include "platform/heap/glue/PendingGCRunner.h"
10 #include "public/platform/Platform.h" 10 #include "public/platform/Platform.h"
11 #include "public/platform/WebThread.h" 11 #include "public/platform/WebThread.h"
12 #include "wtf/Noncopyable.h" 12 #include "wtf/Noncopyable.h"
13 #include "wtf/OwnPtr.h" 13 #include "wtf/OwnPtr.h"
14 #include "wtf/PassOwnPtr.h" 14 #include "wtf/PassOwnPtr.h"
15 15
16 namespace blink { 16 namespace blink {
17 17
18 // WebThreadSupportingGC wraps a WebThread and adds support for attaching 18 // WebThreadSupportingGC wraps a WebThread and adds support for attaching
19 // to and detaching from the Blink GC infrastructure. The attachGC method 19 // to and detaching from the Blink GC infrastructure. The initialize method
20 // must be called during initialization on the WebThread and before the 20 // must be called during initialization on the WebThread and before the
21 // thread allocates any objects managed by the Blink GC. The detach GC 21 // thread allocates any objects managed by the Blink GC. The shutdown
22 // method must be called on the WebThread during shutdown when the thread 22 // method must be called on the WebThread during shutdown when the thread
23 // no longer needs to access objects managed by the Blink GC. 23 // no longer needs to access objects managed by the Blink GC.
24 class PLATFORM_EXPORT WebThreadSupportingGC final { 24 class PLATFORM_EXPORT WebThreadSupportingGC final {
25 WTF_MAKE_NONCOPYABLE(WebThreadSupportingGC); 25 WTF_MAKE_NONCOPYABLE(WebThreadSupportingGC);
26 public: 26 public:
27 static PassOwnPtr<WebThreadSupportingGC> create(const char*); 27 static PassOwnPtr<WebThreadSupportingGC> create(const char*);
28 ~WebThreadSupportingGC(); 28 ~WebThreadSupportingGC();
29 29
30 void postTask(const WebTraceLocation& location, WebThread::Task* task) 30 void postTask(const WebTraceLocation& location, WebThread::Task* task)
31 { 31 {
(...skipping 13 matching lines...) Expand all
45 void addTaskObserver(WebThread::TaskObserver* observer) 45 void addTaskObserver(WebThread::TaskObserver* observer)
46 { 46 {
47 m_thread->addTaskObserver(observer); 47 m_thread->addTaskObserver(observer);
48 } 48 }
49 49
50 void removeTaskObserver(WebThread::TaskObserver* observer) 50 void removeTaskObserver(WebThread::TaskObserver* observer)
51 { 51 {
52 m_thread->removeTaskObserver(observer); 52 m_thread->removeTaskObserver(observer);
53 } 53 }
54 54
55 void attachGC(); 55 void initialize();
56 void detachGC(); 56 void shutdown();
57 57
58 WebThread& platformThread() const 58 WebThread& platformThread() const
59 { 59 {
60 ASSERT(m_thread); 60 ASSERT(m_thread);
61 return *m_thread; 61 return *m_thread;
62 } 62 }
63 63
64 private: 64 private:
65 explicit WebThreadSupportingGC(const char*); 65 explicit WebThreadSupportingGC(const char*);
66 66
67 OwnPtr<PendingGCRunner> m_pendingGCRunner; 67 OwnPtr<PendingGCRunner> m_pendingGCRunner;
68 OwnPtr<MessageLoopInterruptor> m_messageLoopInterruptor; 68 OwnPtr<MessageLoopInterruptor> m_messageLoopInterruptor;
69 69
70 // FIXME: This has to be last because of crbug.com/401397. 70 // FIXME: This has to be last because of crbug.com/401397.
71 // A WorkerThread might get deleted before it had a chance to properly 71 // A WorkerThread might get deleted before it had a chance to properly
72 // shut down. By deleting the WebThread first, we can guarantee that 72 // shut down. By deleting the WebThread first, we can guarantee that
73 // no pending tasks on the thread might want to access any of the other 73 // no pending tasks on the thread might want to access any of the other
74 // members during the WorkerThread's destruction. 74 // members during the WorkerThread's destruction.
75 OwnPtr<WebThread> m_thread; 75 OwnPtr<WebThread> m_thread;
76 }; 76 };
77 77
78 } 78 }
79 79
80 #endif 80 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698