Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1111673003: [chrome/utility] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (Closed)

Created:
5 years, 8 months ago by Pranay
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in chrome utility module. MessageLoopProxy is deprecated. This basically does a search and replace: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). BUG=391045 Committed: https://crrev.com/7e5eaf1cbdc7d66c847db48eb3458ecc1c1587f0 Cr-Commit-Position: refs/heads/master@{#327346}

Patch Set 1 #

Total comments: 9

Patch Set 2 : Fixed Review Comments #

Total comments: 4

Patch Set 3 : Fixed Review Comments for the pattern #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M chrome/utility/image_writer/disk_unmounter_mac.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/utility/image_writer/disk_unmounter_mac.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/utility/media_galleries/ipc_data_source.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/utility/profile_import_handler.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
Pranay
PTAL
5 years, 8 months ago (2015-04-28 05:14:16 UTC) #2
Lei Zhang
https://codereview.chromium.org/1111673003/diff/1/chrome/utility/image_writer/disk_unmounter_mac.h File chrome/utility/image_writer/disk_unmounter_mac.h (right): https://codereview.chromium.org/1111673003/diff/1/chrome/utility/image_writer/disk_unmounter_mac.h#newcode16 chrome/utility/image_writer/disk_unmounter_mac.h:16: #include "base/thread_task_runner_handle.h" not needed in the .h file? https://codereview.chromium.org/1111673003/diff/1/chrome/utility/media_galleries/ipc_data_source.cc ...
5 years, 8 months ago (2015-04-28 05:24:56 UTC) #3
Pranay
Hi Lei Zhang, Thanks for reviewing this patch. I have updated the changes as per ...
5 years, 8 months ago (2015-04-28 05:41:51 UTC) #4
Lei Zhang
Please do not just fix the lines that I pointed out, but rather, notice there's ...
5 years, 8 months ago (2015-04-28 05:47:24 UTC) #5
Pranay
Hi Lei, Sorry, missed those ones. Fixed Review comments again. PTAL
5 years, 8 months ago (2015-04-28 07:09:00 UTC) #6
Lei Zhang
lgtm
5 years, 7 months ago (2015-04-28 18:07:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111673003/40001
5 years, 7 months ago (2015-04-28 18:08:43 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-04-28 19:13:35 UTC) #10
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/7e5eaf1cbdc7d66c847db48eb3458ecc1c1587f0 Cr-Commit-Position: refs/heads/master@{#327346}
5 years, 7 months ago (2015-04-28 19:14:35 UTC) #11
Pranay
5 years, 7 months ago (2015-05-04 03:32:25 UTC) #12
Message was sent while issue was closed. 
Done

https://codereview.chromium.org/1111673003/diff/1/chrome/utility/image_writer...
File chrome/utility/image_writer/disk_unmounter_mac.h (right):

https://codereview.chromium.org/1111673003/diff/1/chrome/utility/image_writer...
chrome/utility/image_writer/disk_unmounter_mac.h:16: #include
"base/thread_task_runner_handle.h"
On 2015/04/28 05:24:56, Lei Zhang wrote:
> not needed in the .h file?

Done.

https://codereview.chromium.org/1111673003/diff/1/chrome/utility/media_galler...
File chrome/utility/media_galleries/ipc_data_source.cc (right):

https://codereview.chromium.org/1111673003/diff/1/chrome/utility/media_galler...
chrome/utility/media_galleries/ipc_data_source.cc:7: #include
"base/message_loop/message_loop_proxy.h"
On 2015/04/28 05:24:56, Lei Zhang wrote:
> remove?

Done.

https://codereview.chromium.org/1111673003/diff/1/chrome/utility/media_galler...
chrome/utility/media_galleries/ipc_data_source.cc:8: #include
"base/single_thread_task_runner.h"
On 2015/04/28 05:24:56, Lei Zhang wrote:
> not needed?

Done.

https://codereview.chromium.org/1111673003/diff/1/chrome/utility/profile_impo...
File chrome/utility/profile_import_handler.h (right):

https://codereview.chromium.org/1111673003/diff/1/chrome/utility/profile_impo...
chrome/utility/profile_import_handler.h:12: #include
"base/single_thread_task_runner.h"
On 2015/04/28 05:24:56, Lei Zhang wrote:
> both of these are not needed in the .h file?

Done.

https://codereview.chromium.org/1111673003/diff/20001/chrome/utility/image_wr...
File chrome/utility/image_writer/disk_unmounter_mac.cc (right):

https://codereview.chromium.org/1111673003/diff/20001/chrome/utility/image_wr...
chrome/utility/image_writer/disk_unmounter_mac.cc:10: #include
"base/message_loop/message_loop_proxy.h"
On 2015/04/28 05:47:24, Lei Zhang wrote:
> Remove this as well? You probably need to add
base/thread_task_runner_handle.h,
> just like in chrome/utility/media_galleries/ipc_data_source.cc.

Done.

https://codereview.chromium.org/1111673003/diff/20001/chrome/utility/profile_...
File chrome/utility/profile_import_handler.h (right):

https://codereview.chromium.org/1111673003/diff/20001/chrome/utility/profile_...
chrome/utility/profile_import_handler.h:12: #include
"base/thread_task_runner_handle.h"
On 2015/04/28 05:47:24, Lei Zhang wrote:
> Also not needed in the header file?

Done.

Powered by Google App Engine
This is Rietveld 408576698