Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(901)

Unified Diff: content/renderer/pepper/video_decoder_shim.h

Issue 1111653004: Replace SW YUV conversion with higher quality Shader+FBO in pepper video path. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added InvalidateGrContext calls for Skia State. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/pepper/video_decoder_shim.h
diff --git a/content/renderer/pepper/video_decoder_shim.h b/content/renderer/pepper/video_decoder_shim.h
index 3a0f32ae592ed93c1331ea24d64c58c52a9943c4..d19d2c0a864f6b0a3d07c4e537df2147a71f1759 100644
--- a/content/renderer/pepper/video_decoder_shim.h
+++ b/content/renderer/pepper/video_decoder_shim.h
@@ -39,6 +39,7 @@ class DecoderBuffer;
namespace content {
+class YUVConverter;
piman 2015/05/12 03:00:25 nit: make it an inner class of VideoDecoderShim
class PepperVideoDecoderHost;
// This class is a shim to wrap a media::VideoDecoder so that it can be used
@@ -109,8 +110,7 @@ class VideoDecoderShim : public media::VideoDecodeAccelerator {
typedef std::queue<uint32_t> CompletedDecodeQueue;
CompletedDecodeQueue completed_decodes_;
- // Queue of decoded frames that have been converted to RGB and await upload to
- // a GL texture.
+ // Queue of decoded frames that await rgb->yuv conversion
piman 2015/05/12 03:00:26 nit: end with a .
typedef std::queue<linked_ptr<PendingFrame> > PendingFrameQueue;
PendingFrameQueue pending_frames_;
@@ -119,6 +119,8 @@ class VideoDecoderShim : public media::VideoDecodeAccelerator {
uint32_t num_pending_decodes_;
+ scoped_ptr<YUVConverter> yuv_converter_;
+
base::WeakPtrFactory<VideoDecoderShim> weak_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(VideoDecoderShim);
« no previous file with comments | « no previous file | content/renderer/pepper/video_decoder_shim.cc » ('j') | content/renderer/pepper/video_decoder_shim.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698