Move StyleInvalidator to StyleEngine.

Move StyleInvalidator to StyleEngine.

This is part of componentizing style resolving. We want to get rid of as
much as possible of global style data like RuleFeatureSet. We decouple the
StyleInvalidator from RuleFeatureSet and keep a single StyleInvalidator
in the StyleEngine. This removes a bunch of unused StyleInvalidators from
other RuleFeatureSets than the global one.

The plan ahead is to collect invalidation sets from rulesets in tree
scopes instead of the global one.

BUG=401359
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194726

[rune, 2015-04-28 11:04:13]

rune@opera.com changed reviewers:
+ esprehn@chromium.org, kochi@chromium.org

[rune, 2015-04-29 10:43:42]

PTAL

[esprehn, 2015-04-30 05:40:24]

lgtm

https://1c9a255-dot-chromiumcodereview-hr.appspot.com/1111643003/diff/1/Sourc...
File Source/core/dom/StyleEngine.cpp (right):

https://1c9a255-dot-chromiumcodereview-hr.appspot.com/1111643003/diff/1/Sourc...
Source/core/dom/StyleEngine.cpp:703:
ensureResolver().ensureUpdatedRuleFeatureSet().collectInvalidationSetsForClass(invalidationSets,
element, changedClasses[i]);
I don't think you want to call ensureUpdatedRuleFeatureSet inside a loop. Save
the value and use that?

https://1c9a255-dot-chromiumcodereview-hr.appspot.com/1111643003/diff/1/Sourc...
Source/core/dom/StyleEngine.cpp:740:
ensureResolver().ensureUpdatedRuleFeatureSet().collectInvalidationSetsForClass(invalidationSets,
element, oldClasses[i]);
ditto. Don't want to call ensureResolver or ensureUpdatedRuleFeatureSet in a
loop.

[rune, 2015-04-30 08:05:57]

https://codereview.chromium.org/1111643003/diff/1/Source/core/dom/StyleEngine...
File Source/core/dom/StyleEngine.cpp (right):

https://codereview.chromium.org/1111643003/diff/1/Source/core/dom/StyleEngine...
Source/core/dom/StyleEngine.cpp:703:
ensureResolver().ensureUpdatedRuleFeatureSet().collectInvalidationSetsForClass(invalidationSets,
element, changedClasses[i]);
On 2015/04/30 05:40:24, esprehn wrote:
> I don't think you want to call ensureUpdatedRuleFeatureSet inside a loop. Save
> the value and use that?

Done.

https://codereview.chromium.org/1111643003/diff/1/Source/core/dom/StyleEngine...
Source/core/dom/StyleEngine.cpp:740:
ensureResolver().ensureUpdatedRuleFeatureSet().collectInvalidationSetsForClass(invalidationSets,
element, oldClasses[i]);
On 2015/04/30 05:40:24, esprehn wrote:
> ditto. Don't want to call ensureResolver or ensureUpdatedRuleFeatureSet in a
> loop.

Done.

[rune, 2015-04-30 08:06:06]

The CQ bit was checked by rune@opera.com

[rune, 2015-04-30 08:06:07]

The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/1111643003/#ps20001
(title: "Avoid calling ensureUpdatedRuleFeatureSet multiple times")

[commit-bot: I haz the power, 2015-04-30 08:06:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1111643003/20001

[commit-bot: I haz the power, 2015-04-30 10:46:48]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194726