Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1111603003: Subzero: Fix asm (non-ELF) output files. (Closed)

Created:
5 years, 7 months ago by Jim Stichnoth
Modified:
5 years, 7 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Fix asm (non-ELF) output files. In an earlier version of Subzero, the text output stream object was stack-allocated within main. A later refactoring moved its allocation into a helper function, but it was still being stack-allocated, which was bad when the helper function returned. This change allocates the object via "new", which fixes that problem, but reveals another problem: the raw_ostream object for some reason doesn't finish writing everything to disk and yielding a truncated output file. This is solved in the style of the ELF streamer, by using raw_fd_ostream instead. BUG= none R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=620ad732db0def93eee3928f9ebebe88b279f63d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -16 lines) Patch
M src/IceBrowserCompileServer.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/IceCompileServer.cpp View 5 chunks +19 lines, -11 lines 0 comments Download
M src/IceGlobalContext.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jim Stichnoth
(The .h files are whitespace-only changes, thanks to "make format".)
5 years, 7 months ago (2015-04-27 22:58:38 UTC) #2
Karl
lgtm
5 years, 7 months ago (2015-04-28 18:05:14 UTC) #3
Jim Stichnoth
5 years, 7 months ago (2015-04-28 21:12:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
620ad732db0def93eee3928f9ebebe88b279f63d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698