Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: remoting/webapp/crd/js/host_list_api_impl_unittest.js

Issue 1111603002: Added ability to register new hosts using GCD. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@host-list-delete
Patch Set: unit test fix Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/webapp/crd/js/host_list_api_impl.js ('k') | remoting/webapp/crd/js/mock_host_list_api.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/crd/js/host_list_api_impl_unittest.js
diff --git a/remoting/webapp/crd/js/host_list_api_impl_unittest.js b/remoting/webapp/crd/js/host_list_api_impl_unittest.js
index 3fe3432794ecebedd7cd22c52b8ec117ec8e8829..4e7bc3d861ca63d9892272306399eb32f14221b9 100644
--- a/remoting/webapp/crd/js/host_list_api_impl_unittest.js
+++ b/remoting/webapp/crd/js/host_list_api_impl_unittest.js
@@ -31,17 +31,13 @@ QUnit.module('host_list_api_impl', {
/**
* Install an HTTP response for requests to the registry.
* @param {QUnit.Assert} assert
- * @param {boolean} withAuthCode
*/
-function queueRegistryResponse(assert, withAuthCode) {
+function queueRegistryResponse(assert) {
var responseJson = {
data: {
authorizationCode: FAKE_AUTH_CODE
}
};
- if (!withAuthCode) {
- delete responseJson.data.authorizationCode;
- }
remoting.MockXhr.setResponseFor(
'POST', 'DIRECTORY_API_BASE_URL/@me/hosts',
@@ -57,29 +53,17 @@ function queueRegistryResponse(assert, withAuthCode) {
});
}
-QUnit.test('register with auth code', function(assert) {
- var impl = new remoting.HostListApiImpl();
- queueRegistryResponse(assert, true);
- return impl.register(
- FAKE_HOST_ID,
- FAKE_HOST_NAME,
- FAKE_PUBLIC_KEY,
- FAKE_HOST_CLIENT_ID
- ). then(function(authCode) {
- assert.equal(authCode, FAKE_AUTH_CODE);
- });
-});
-
-QUnit.test('register without auth code', function(assert) {
+QUnit.test('register', function(assert) {
var impl = new remoting.HostListApiImpl();
- queueRegistryResponse(assert, false);
+ queueRegistryResponse(assert);
return impl.register(
FAKE_HOST_ID,
FAKE_HOST_NAME,
FAKE_PUBLIC_KEY,
FAKE_HOST_CLIENT_ID
- ). then(function(authCode) {
- assert.equal(authCode, '');
+ ). then(function(regResult) {
+ assert.equal(regResult.authCode, FAKE_AUTH_CODE);
+ assert.equal(regResult.email, '');
});
});
« no previous file with comments | « remoting/webapp/crd/js/host_list_api_impl.js ('k') | remoting/webapp/crd/js/mock_host_list_api.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698