Added ability to register new hosts using GCD.

remoting/webapp/crd/js/host_controller_unittest.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Unit tests for host_controller.js.
  */
 
 (function() {
@@ skipping 63 matching lines @@
 /** @type {remoting.MockHostListApi} */
 var mockHostListApi;
 
 QUnit.module('host_controller', {
   beforeEach: function(/** QUnit.Assert */ assert) {
     chromeMocks.activate(['identity', 'runtime']);
     chromeMocks.identity.mock$setToken(FAKE_IDENTITY_TOKEN);
     remoting.settings = new remoting.Settings();
     remoting.identity = new remoting.Identity();
     mockHostListApi = new remoting.MockHostListApi;
-    mockHostListApi.registerResult = FAKE_AUTH_CODE;
+    mockHostListApi.authCodeFromRegister = FAKE_AUTH_CODE;
+    mockHostListApi.emailFromRegister = '';
     remoting.HostListApi.setInstance(mockHostListApi);
     base.debug.assert(remoting.oauth2 === null);
     remoting.oauth2 = new remoting.OAuth2();
     base.debug.assert(remoting.hostList === null);
     remoting.hostList = /** @type {remoting.HostList} */
         (Object.create(remoting.HostList.prototype));
 
     // When the HostList's unregisterHostById method is called, make
     // sure the argument is correct.
     unregisterHostByIdSpy =
@@ skipping 148 matching lines @@
     assert.equal(e.getTag(), remoting.Error.Tag.UNEXPECTED);
     assert.equal(unregisterHostByIdSpy.callCount, 0);
     assert.equal(onLocalHostStartedSpy.callCount, 0);
     assert.equal(startDaemonSpy.callCount, 0);
   });
 });
 
 // Check what happens when the registry returns an HTTP when we try to
 // register a host.
 QUnit.test('start with host registration failure', function(assert) {
-  mockHostListApi.registerResult = null;
+  mockHostListApi.authCodeFromRegister = null;
   return controller.start(FAKE_HOST_PIN, true).then(function() {
     throw 'test failed';
   }, function(/** remoting.Error */ e) {
     assert.equal(e.getTag(), remoting.Error.Tag.REGISTRATION_FAILED);
     assert.equal(unregisterHostByIdSpy.callCount, 0);
     assert.equal(onLocalHostStartedSpy.callCount, 0);
     assert.equal(startDaemonSpy.callCount, 0);
   });
 });
 
 // Check what happens when the HostDaemonFacade's
 // getCredentialsFromAuthCode method fails.
 QUnit.test('start with getCredentialsFromAuthCode failure', function(assert) {
   mockHostDaemonFacade.useEmail = null;
   mockHostDaemonFacade.refreshToken = null;
   return controller.start(FAKE_HOST_PIN, true).then(function() {
     throw 'test failed';
   }, function(/** remoting.Error */ e) {
     assert.equal(e.getDetail(), 'getCredentialsFromAuthCode');
     assert.equal(e.getTag(), remoting.Error.Tag.UNEXPECTED);
     assert.equal(getCredentialsFromAuthCodeSpy.callCount, 1);
     assert.equal(onLocalHostStartedSpy.callCount, 0);
     assert.equal(startDaemonSpy.callCount, 0);
   });
 });
 
-// Check what happens when the HostDaemonFacade's getPinHash method
-// fails, and verify that getPinHash is called when the registry
-// does't return an auth code.
-QUnit.test('start with getRefreshToken+getPinHash failure', function(assert) {
-  mockHostDaemonFacade.pinHashFunc = null;
-  mockHostListApi.registerResult = '';
-  return controller.start(FAKE_HOST_PIN, true).then(function() {
-    throw 'test failed';
-  }, function(/** remoting.Error */ e) {
-    assert.equal(e.getDetail(), 'getPinHash');
-    assert.equal(e.getTag(), remoting.Error.Tag.UNEXPECTED);
-    assert.equal(onLocalHostStartedSpy.callCount, 0);
-    assert.equal(startDaemonSpy.callCount, 0);
-  });
-});
-
 // Check what happens when the SignalStrategy fails to connect.
 QUnit.test('start with signalStrategy failure', function(assert) {
   stubSignalStrategyConnect(false);
   return controller.start(FAKE_HOST_PIN, true).then(function() {
     throw 'test failed';
   }, function(/** remoting.Error */ e) {
     assert.equal(e.getDetail(), 'setStateForTesting');
     assert.equal(e.getTag(), remoting.Error.Tag.UNEXPECTED);
     assert.equal(unregisterHostByIdSpy.callCount, 1);
   });
@@ skipping 43 matching lines @@
   }, function(/** remoting.Error */ e) {
     assert.equal(e.getTag(), remoting.Error.Tag.UNEXPECTED);
     assert.equal(unregisterHostByIdSpy.callCount, 1);
     assert.equal(onLocalHostStartedSpy.callCount, 0);
   });
 });
 
 // Check what happens when the entire host registration process
 // succeeds.
 [false, true].forEach(function(/** boolean */ consent) {
-  QUnit.test('start with auth code, consent=' + consent, function(assert) {
+  QUnit.test('start with consent=' + consent, function(assert) {
     /** @const */
     var fakePinHash = fakePinHashFunc(FAKE_HOST_ID, FAKE_HOST_PIN);
     stubSignalStrategyConnect(true);
     return controller.start(FAKE_HOST_PIN, consent).then(function() {
       assert.equal(getCredentialsFromAuthCodeSpy.callCount, 1);
       assert.deepEqual(
           getCredentialsFromAuthCodeSpy.args[0][0],
           FAKE_AUTH_CODE);
       assert.equal(getPinHashSpy.callCount, 1);
       assert.deepEqual(
@@ skipping 11 matching lines @@
             host_owner_email: FAKE_USER_EMAIL,
             host_id: FAKE_HOST_ID,
             host_name: FAKE_HOST_NAME,
             host_secret_hash: fakePinHash,
             private_key: FAKE_PRIVATE_KEY
           }, consent]);
     });
   });
 });
 
-// Check alternative host registration without a registry-supplied
-// auth code.
-[false, true].forEach(function(/** boolean */ consent) {
-  QUnit.test('start without auth code, consent=' + consent, function(assert) {
-    /** @const */
-    var fakePinHash = fakePinHashFunc(FAKE_HOST_ID, FAKE_HOST_PIN);
-    mockHostListApi.registerResult = '';
-    stubSignalStrategyConnect(true);
-    return controller.start(FAKE_HOST_PIN, consent).then(function() {
-      assert.equal(getCredentialsFromAuthCodeSpy.callCount, 0);
-      assert.equal(getPinHashSpy.callCount, 1);
-      assert.deepEqual(
-          getPinHashSpy.args[0].slice(0, 2),
-          [FAKE_HOST_ID, FAKE_HOST_PIN]);
-      assert.equal(unregisterHostByIdSpy.callCount, 0);
-      assert.equal(onLocalHostStartedSpy.callCount, 1);
-      assert.equal(startDaemonSpy.callCount, 1);
-      assert.deepEqual(
-          startDaemonSpy.args[0].slice(0, 2),
-          [{
-            xmpp_login: FAKE_USER_EMAIL,
-            oauth_refresh_token: FAKE_REFRESH_TOKEN,
-            host_id: FAKE_HOST_ID,
-            host_name: FAKE_HOST_NAME,
-            host_secret_hash: fakePinHash,
-            private_key: FAKE_PRIVATE_KEY
-          }, consent]);
-    });
-  });
-});
-
 // Check what happens when stopDaemon calls onError.
 // TODO(jrw): Should stopDaemon even have an onError callback?
 QUnit.test('stop with stopDaemon failure', function(assert) {
   mockHostDaemonFacade.stopDaemonResult = null;
   return new Promise(function(resolve, reject) {
     controller.stop(function() {
       reject('test failed');
     }, function(/** remoting.Error */ e) {
       assert.equal(e.getDetail(), 'stopDaemon');
       // TODO(jrw): Is it really desirable to leave the host registered?
@@ skipping 205 matching lines @@
       resolve(null);
     });
   });
 });
 
 // Tests omitted for hasFeature, getPairedClients, deletePairedClient,
 // and clearPairedClients because they simply call through to
 // HostDaemonFacade.
 
 })();