Added ability to register new hosts using GCD.

Added ability to register new hosts using GCD.

Hosts registered through GCD can't be brought online yet, because the
host doesn't know how to use the XMPP credentials it gets from GCD.

BUG=471928
Committed: https://crrev.com/0157b3db789f73aa3cb8e507c5b65cf36b0dbdd7
Cr-Commit-Position: refs/heads/master@{#327427}

[John Williams, 2015-04-27 22:50:11]

jrw@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[Jamie, 2015-04-27 23:24:24]

https://codereview.chromium.org/1111603002/diff/20001/remoting/webapp/crd/js/...
File remoting/webapp/crd/js/host_controller.js (right):

https://codereview.chromium.org/1111603002/diff/20001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/host_controller.js:174: // string.
Is this comment still correct?

https://codereview.chromium.org/1111603002/diff/20001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/host_controller.js:213: refreshToken:
remoting.oauth2.getRefreshToken()
remoting.oauth2 is null for v2, so I think this should just be an assert.
Something like:

base.assert(result.authCode);
if (result.email) {
  // GCD
} else {
  // Chromoting
}

https://codereview.chromium.org/1111603002/diff/20001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/host_controller.js:221: if (regResult.authCode &&
!regResult.email) {
This doesn't look right. You're never using regResult.email, even if it's
present.

https://codereview.chromium.org/1111603002/diff/20001/remoting/webapp/crd/js/...
File remoting/webapp/crd/js/host_list_api_impl.js (right):

https://codereview.chromium.org/1111603002/diff/20001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/host_list_api_impl.js:49: return { authCode: authCode,
email: '' };
Rather than adding code at call sites to deal with there being no email, why not
fill it in here?

[John Williams, 2015-04-28 20:27:41]

https://codereview.chromium.org/1111603002/diff/20001/remoting/webapp/crd/js/...
File remoting/webapp/crd/js/host_controller.js (right):

https://codereview.chromium.org/1111603002/diff/20001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/host_controller.js:174: // string.
On 2015/04/27 23:24:24, Jamie wrote:
> Is this comment still correct?

Fixed.

https://codereview.chromium.org/1111603002/diff/20001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/host_controller.js:213: refreshToken:
remoting.oauth2.getRefreshToken()
On 2015/04/27 23:24:24, Jamie wrote:
> remoting.oauth2 is null for v2, so I think this should just be an assert.
> Something like:
> 
> base.assert(result.authCode);
> if (result.email) {
>   // GCD
> } else {
>   // Chromoting
> }

Done.

https://codereview.chromium.org/1111603002/diff/20001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/host_controller.js:221: if (regResult.authCode &&
!regResult.email) {
On 2015/04/27 23:24:24, Jamie wrote:
> This doesn't look right. You're never using regResult.email, even if it's
> present.

Done.

https://codereview.chromium.org/1111603002/diff/20001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/host_controller.js:255: var hostConfigWithOwnerPromise =
Promise.all([
I merged this with the function above since I realized there's no reason for
them to be separate.

https://codereview.chromium.org/1111603002/diff/20001/remoting/webapp/crd/js/...
File remoting/webapp/crd/js/host_list_api_impl.js (right):

https://codereview.chromium.org/1111603002/diff/20001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/host_list_api_impl.js:49: return { authCode: authCode,
email: '' };
On 2015/04/27 23:24:24, Jamie wrote:
> Rather than adding code at call sites to deal with there being no email, why
not
> fill it in here?

The call site already has to fetch the user's email address, and filling in a
missing email address is logically part of building the host config and not part
of registering the host.  I don't want to clutter this method with things that
don't involve communicating with the registry.

https://codereview.chromium.org/1111603002/diff/60001/remoting/webapp/crd/js/...
File remoting/webapp/crd/js/host_controller_unittest.js (right):

https://codereview.chromium.org/1111603002/diff/60001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/host_controller_unittest.js:281: // Check what happens
when the HostDaemonFacade's getPinHash method
Irrelevant now that the auth code is mandatory.

https://codereview.chromium.org/1111603002/diff/60001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/host_controller_unittest.js:392: // Check alternative
host registration without a registry-supplied
Irrelevant now that the auth code is mandatory.

https://codereview.chromium.org/1111603002/diff/100001/remoting/webapp/crd/js...
File remoting/webapp/crd/js/host_list_api_impl.js (right):

https://codereview.chromium.org/1111603002/diff/100001/remoting/webapp/crd/js...
remoting/webapp/crd/js/host_list_api_impl.js:46: var authCode =
base.getStringAttr(data, 'authorizationCode');
Simplified based on the assumption that the auth code will must always be
provided.

[Jamie, 2015-04-28 20:55:31]

lgtm

[John Williams, 2015-04-28 21:06:47]

The CQ bit was checked by jrw@chromium.org

[commit-bot: I haz the power, 2015-04-28 21:07:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1111603002/100001

[commit-bot: I haz the power, 2015-04-28 22:22:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-28 22:22:21]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[John Williams, 2015-04-29 00:20:36]

The CQ bit was checked by jrw@chromium.org

[John Williams, 2015-04-29 00:20:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamiewalch@chromium.org
Link to the patchset: https://codereview.chromium.org/1111603002/#ps120001
(title: "unit test fix")

[commit-bot: I haz the power, 2015-04-29 00:22:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1111603002/120001

[commit-bot: I haz the power, 2015-04-29 03:06:36]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-04-29 03:07:49]

Patchset 7 (id:??) landed as
https://crrev.com/0157b3db789f73aa3cb8e507c5b65cf36b0dbdd7
Cr-Commit-Position: refs/heads/master@{#327427}