Flapper has some additional environment expectations.

Flapper has some additional environment expectations.

Flash has some third-party code which depends on additional
environment settings over what we pass to ICU.

BUG=155396, 134911
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161813

[brettw, 2012-10-12 05:50:52]

https://codereview.chromium.org/11116008/diff/1/content/ppapi_plugin/ppapi_pl...
File content/ppapi_plugin/ppapi_plugin_main.cc (right):

https://codereview.chromium.org/11116008/diff/1/content/ppapi_plugin/ppapi_pl...
content/ppapi_plugin/ppapi_plugin_main.cc:60: setenv("LANG", locale.c_str(), 0);
Can you add a comment about why this is needed?

[Scott Hess - ex-Googler, 2012-10-12 06:15:05]

https://codereview.chromium.org/11116008/diff/1/content/ppapi_plugin/ppapi_pl...
File content/ppapi_plugin/ppapi_plugin_main.cc (right):

https://codereview.chromium.org/11116008/diff/1/content/ppapi_plugin/ppapi_pl...
content/ppapi_plugin/ppapi_plugin_main.cc:60: setenv("LANG", locale.c_str(), 0);
On 2012/10/12 05:50:53, brettw wrote:
> Can you add a comment about why this is needed?

Done.  I'll poke around tomorrow morning and see if I can't make the comment
more specific or something (I only have chromium code access out here).

[brettw, 2012-10-12 18:03:42]

lgtm

[commit-bot: I haz the power, 2012-10-13 00:34:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shess@chromium.org/11116008/1002

[commit-bot: I haz the power, 2012-10-13 00:52:58]

Sorry for I got bad news for ya.
Compile failed with a clobber build.
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[Scott Hess - ex-Googler, 2012-10-13 01:12:29]

On 2012/10/13 00:52:58, I haz the power (commit-bot) wrote:
> Sorry for I got bad news for ya.
> Compile failed with a clobber build.
> Your code is likely broken or HEAD is junk. Please ensure your
> code is not broken then alert the build sheriffs.
> Look at the try server FAQ for more details.

Scott iz idiot.

[commit-bot: I haz the power, 2012-10-13 16:51:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shess@chromium.org/11116008/17002

[commit-bot: I haz the power, 2012-10-13 17:30:28]

Retried try job too often for step(s) base_unittests, browser_tests,
cacheinvalidation_unittests, check_deps, content_browsertests,
content_unittests, crypto_unittests, gpu_unittests, interactive_ui_tests,
ipc_tests, jingle_unittests, media_unittests, net_unittests, printing_unittests,
sandbox_linux_unittests, sql_unittests, sync_unit_tests, unit_tests

[Scott Hess - ex-Googler, 2012-10-14 18:55:11]

On 2012/10/13 17:30:28, I haz the power (commit-bot) wrote:
> Retried try job too often for step(s) base_unittests, browser_tests,
> cacheinvalidation_unittests, check_deps, content_browsertests,
> content_unittests, crypto_unittests, gpu_unittests, interactive_ui_tests,
> ipc_tests, jingle_unittests, media_unittests, net_unittests,
printing_unittests,
> sandbox_linux_unittests, sql_unittests, sync_unit_tests, unit_tests

I don't know what this is telling me.  linux_chromeos failed compiling
texture_update_controller, so that's not it.  win_rel looks like it died on a
bot exception.

I dunno, like a hairy primate I'm just going to press the button again.  Maybe
this time I'll get a grape.

[commit-bot: I haz the power, 2012-10-14 18:55:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shess@chromium.org/11116008/17002

[commit-bot: I haz the power, 2012-10-14 20:34:07]

Change committed as 161813