Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1111593006: Revert of Revert "Enable BlockingLoginTest, ForceMaximizeOnFirstRunTest, UserCloudPolicyManagerTest (Closed)

Created:
5 years, 7 months ago by achuithb
Modified:
5 years, 7 months ago
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert "Enable BlockingLoginTest, ForceMaximizeOnFirstRunTest, UserCloudPolicyManagerTest, for webv… (patchset #1 id:1 of https://codereview.chromium.org/1109393005/) Reason for revert: This was a speculative revert, but I don't believe the browser tests reverted here were the cause of the blink failures. Original issue's description: > Revert "Enable BlockingLoginTest, ForceMaximizeOnFirstRunTest, UserCloudPolicyManagerTest, for webview." > > This reverts commit 8c52ec023857ec7d082d54518864edd84d25b116. > > This seems to be breaking "Linux ChromiumOS Tests (dbg)" on the Blink waterfall, and blocking the Blink roll: > http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/1485 > > TBR=achuith,nkostylev@chromium.org > BUG= > NOTREECHECKS=true > > Committed: https://crrev.com/a5080f268e879b41a34a3f912fb5dabfc6b7a2dd > Cr-Commit-Position: refs/heads/master@{#327552} TBR=nkostylev@chromium.org,macourteau@chromium.org,senorblanco@chromium.org BUG=475567, 477402 Committed: https://crrev.com/c73fce65a5963c8013e8a0a2b0251ba7c02bfccc Cr-Commit-Position: refs/heads/master@{#327611}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -67 lines) Patch
M chrome/browser/chromeos/login/existing_user_controller.cc View 2 chunks +17 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/policy/blocking_login_browsertest.cc View 5 chunks +40 lines, -36 lines 0 comments Download
M chrome/browser/chromeos/policy/force_maximize_on_first_run_chromeos_browsertest.cc View 6 chunks +20 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_browsertest.cc View 3 chunks +12 lines, -3 lines 0 comments Download
M chromeos/login/auth/auth_status_consumer.h View 2 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
achuithb
Created Revert of Revert "Enable BlockingLoginTest, ForceMaximizeOnFirstRunTest, UserCloudPolicyManagerTest, for webv…
5 years, 7 months ago (2015-04-29 22:44:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111593006/1
5 years, 7 months ago (2015-04-29 22:47:14 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 23:22:04 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 23:22:59 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c73fce65a5963c8013e8a0a2b0251ba7c02bfccc
Cr-Commit-Position: refs/heads/master@{#327611}

Powered by Google App Engine
This is Rietveld 408576698