Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1111583002: Retry aa3219ce27ef5471c19670fe5145b136925cbc89: (Closed)

Created:
5 years, 8 months ago by Evan Stade
Modified:
5 years, 8 months ago
Reviewers:
Lei Zhang, brettw
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, browser-components-watch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Retry aa3219ce27ef5471c19670fe5145b136925cbc89: Limit form-less Autofilling to pages that look like checkout pages. This should hopefully stem the tide of false positives on non-checkout pages, while preserving desired behavior on Best Buy and Apple checkout. Fixing FormStructureBrowserTests: I went back and added <form>s that were present in the source pages but not in the local copies. I also added the original <title> tags, except for ones that did /not/ include any of the checkout keywords. For these, I added the checkout keywords to the title, so that the test still had some value (instead of passing trivially because the title was "Google Calendar" and not something like "Payment information"). BUG=471090, 477466 original review: https://codereview.chromium.org/1081803003/ TBR=brettw@chromium.org, thestig@chromium.org Committed: https://crrev.com/ffdf17b0b87c2120c8fd1292f3c78466856efbab Cr-Commit-Position: refs/heads/master@{#327215}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+922 lines, -256 lines) Patch
M chrome/renderer/autofill/form_autofill_browsertest.cc View 28 chunks +39 lines, -19 lines 0 comments Download
M chrome/test/data/autofill/autofill_noform_dynamic.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/autofill/heuristics/input/25_checkout_m_llbean.com.html View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/input/b465571.html View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/input/bug_454366.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/autofill/heuristics/input/bug_454366b.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/autofill/heuristics/input/bug_459132.html View 4 chunks +756 lines, -6 lines 0 comments Download
M chrome/test/data/autofill/heuristics/input/bug_460832.html View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/input/bug_462080.html View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/input/bug_463856.html View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/input/bug_465053.html View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/input/bug_465576.html View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/input/bug_471748.html View 1 chunk +39 lines, -34 lines 0 comments Download
M chrome/test/data/autofill/heuristics/input/bug_471831.html View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/b465571.out View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/bug_459132.out View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/bug_465576.out View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/autofill/heuristics/output/bug_471748.out View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill.gypi View 3 chunks +5 lines, -2 lines 0 comments Download
M components/autofill/content/renderer/form_autofill_util.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/renderer/form_autofill_util.cc View 4 chunks +23 lines, -6 lines 0 comments Download
M components/autofill/content/renderer/form_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
D components/autofill/core/browser/autofill_regexes.h View 1 chunk +0 lines, -20 lines 0 comments Download
D components/autofill/core/browser/autofill_regexes.cc View 1 chunk +0 lines, -80 lines 0 comments Download
D components/autofill/core/browser/autofill_regexes_unittest.cc View 1 chunk +0 lines, -66 lines 0 comments Download
M components/autofill/core/browser/credit_card.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/credit_card_field.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/form_field.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/validation.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/autofill/core/common/BUILD.gn View 2 chunks +5 lines, -0 lines 1 comment Download
A + components/autofill/core/common/autofill_regexes.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/autofill/core/common/autofill_regexes.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/autofill/core/common/autofill_regexes_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/components_tests.gyp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Evan Stade
https://codereview.chromium.org/1111583002/diff/1/components/autofill/core/common/BUILD.gn File components/autofill/core/common/BUILD.gn (right): https://codereview.chromium.org/1111583002/diff/1/components/autofill/core/common/BUILD.gn#newcode51 components/autofill/core/common/BUILD.gn:51: configs += [ "//build/config/compiler:no_size_t_to_int_warning" ] this is the difference ...
5 years, 8 months ago (2015-04-27 22:41:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111583002/1
5 years, 8 months ago (2015-04-27 22:42:54 UTC) #3
brettw
lgtm
5 years, 8 months ago (2015-04-27 23:54:28 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/51341)
5 years, 8 months ago (2015-04-28 00:32:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111583002/1
5 years, 8 months ago (2015-04-28 00:40:47 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-28 01:31:22 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-28 01:32:16 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ffdf17b0b87c2120c8fd1292f3c78466856efbab
Cr-Commit-Position: refs/heads/master@{#327215}

Powered by Google App Engine
This is Rietveld 408576698