Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js

Issue 1111563006: [CacheStorage] Entry deletion and cache refresh in Inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added refresh Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/resources/serviceWorkerCacheViews.css ('k') | Source/devtools/protocol.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js
diff --git a/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js b/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js
index 899c5adc333418e6676deb083d0309da9be08d00..68c9ff0c4f824f26fde11fd779c88a29a37b02ee 100644
--- a/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js
+++ b/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js
@@ -69,6 +69,24 @@ WebInspector.ServiceWorkerCacheModel.prototype = {
/**
* @param {!WebInspector.ServiceWorkerCacheModel.Cache} cache
+ * @param {string} request
+ * @param {function()} callback
+ */
+ deleteCacheEntry: function(cache, request, callback)
+ {
+ function _callback(error)
pfeldman 2015/04/29 09:53:02 myCallback, annotate
dmurph 2015/04/29 20:57:47 Done.
+ {
+ if (error) {
+ console.error("ServiceWorkerCacheAgent error deleting cache entry ", request, " in cache ", cache.toString(), ": ", error);
pfeldman 2015/04/29 09:53:02 WebInspector.console.error(WebInspector.UIString("
dmurph 2015/04/29 20:57:47 Done.
+ return;
+ }
+ callback();
+ }
+ this._agent.deleteEntry(cache.cacheId, request, _callback);
+ },
+
+ /**
+ * @param {!WebInspector.ServiceWorkerCacheModel.Cache} cache
* @param {number} skipCount
* @param {number} pageSize
* @param {function(!Array.<!WebInspector.ServiceWorkerCacheModel.Entry>, boolean)} callback
@@ -233,9 +251,7 @@ WebInspector.ServiceWorkerCacheModel.prototype = {
}
var entries = [];
for (var i = 0; i < dataEntries.length; ++i) {
- var request = WebInspector.RemoteObject.fromLocalObject(JSON.parse(dataEntries[i].request));
- var response = WebInspector.RemoteObject.fromLocalObject(JSON.parse(dataEntries[i].response));
- entries.push(new WebInspector.ServiceWorkerCacheModel.Entry(request, response));
+ entries.push(new WebInspector.ServiceWorkerCacheModel.Entry(dataEntries[i].request, dataEntries[i].response));
}
callback(entries, hasMore);
}
@@ -247,8 +263,8 @@ WebInspector.ServiceWorkerCacheModel.prototype = {
/**
* @constructor
- * @param {!WebInspector.RemoteObject} request
- * @param {!WebInspector.RemoteObject} response
+ * @param {string} request
+ * @param {string} response
*/
WebInspector.ServiceWorkerCacheModel.Entry = function(request, response)
{
« no previous file with comments | « Source/devtools/front_end/resources/serviceWorkerCacheViews.css ('k') | Source/devtools/protocol.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698