Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1111563006: [CacheStorage] Entry deletion and cache refresh in Inspector. (Closed)

Created:
5 years, 7 months ago by dmurph
Modified:
5 years, 7 months ago
Reviewers:
pfeldman, horo
CC:
aandrey+blink_chromium.org, apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[CacheStorage] Entry deletion and cache refresh in Inspector. Currently, all behind context menus. BUG=474455 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194770

Patch Set 1 #

Patch Set 2 : Added refresh #

Total comments: 4

Patch Set 3 : Test and comments #

Patch Set 4 : Test and comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -43 lines) Patch
A + LayoutTests/http/tests/inspector/cache-storage/cache-entry-deletion.html View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
A + LayoutTests/http/tests/inspector/cache-storage/cache-entry-deletion-expected.txt View 1 2 1 chunk +6 lines, -8 lines 0 comments Download
M LayoutTests/http/tests/inspector/cache-storage/cache-storage-test.js View 1 2 3 4 chunks +56 lines, -9 lines 0 comments Download
M Source/devtools/front_end/resources/ServiceWorkerCacheViews.js View 1 4 chunks +13 lines, -13 lines 0 comments Download
M Source/devtools/front_end/resources/serviceWorkerCacheViews.css View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js View 1 2 3 chunks +25 lines, -5 lines 0 comments Download
M Source/devtools/protocol.json View 1 2 chunks +11 lines, -2 lines 0 comments Download
M Source/modules/cachestorage/InspectorCacheStorageAgent.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/cachestorage/InspectorCacheStorageAgent.cpp View 1 5 chunks +77 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
dmurph
Hello horo & pfeldman, Can you please take a look at this patch? It adds ...
5 years, 7 months ago (2015-04-29 00:57:07 UTC) #2
pfeldman
looks good to me, waiting for the test. https://codereview.chromium.org/1111563006/diff/20001/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js File Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js (right): https://codereview.chromium.org/1111563006/diff/20001/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js#newcode77 Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js:77: function ...
5 years, 7 months ago (2015-04-29 09:53:03 UTC) #3
dmurph
Done, PTAL :) https://codereview.chromium.org/1111563006/diff/20001/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js File Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js (right): https://codereview.chromium.org/1111563006/diff/20001/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js#newcode77 Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js:77: function _callback(error) On 2015/04/29 at 09:53:02, ...
5 years, 7 months ago (2015-04-29 20:57:47 UTC) #4
horo
lgtm
5 years, 7 months ago (2015-04-30 01:52:51 UTC) #5
pfeldman
lgtm
5 years, 7 months ago (2015-04-30 09:46:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111563006/60001
5 years, 7 months ago (2015-04-30 18:59:36 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 20:15:17 UTC) #9
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194770

Powered by Google App Engine
This is Rietveld 408576698