Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1111563002: Revert of Add CPP API for BLE advertisments. (Closed)

Created:
5 years, 8 months ago by spang
Modified:
5 years, 8 months ago
CC:
chromium-reviews, scheib+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, hashimoto+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add CPP API for BLE advertisments. (patchset #12 id:220001 of https://codereview.chromium.org/1054743003/) Reason for revert: Breaks component=shared_library build (missing export?) ../../device/bluetooth/bluetooth_adapter_chromeos.cc:321: error: undefined reference to 'chromeos::BluetoothAdvertisementChromeOS::BluetoothAdvertisementChromeOS(scoped_ptr<device::BluetoothAdvertisement::Data, base::DefaultDeleter<device::BluetoothAdvertisement::Data> >, scoped_refptr<chromeos::BluetoothAdapterChromeOS>)' ../../base/memory/scoped_ptr.h:128: error: undefined reference to 'device::BluetoothAdvertisement::Data::~Data()' ../../device/bluetooth/bluetooth_adapter_chromeos.cc:322: error: undefined reference to 'chromeos::BluetoothAdvertisementChromeOS::Register(base::Callback<void ()> const&, base::Callback<void (device::BluetoothAdvertisement::ErrorCode)> const&)' obj/device/bluetooth/device_bluetooth.bluetooth_adapter_chromeos.o(.debug_addr+0x6f20): error: undefined reference to 'chromeos::BluetoothAdvertisementChromeOS::Register(base::Callback<void ()> const&, base::Callback<void (device::BluetoothAdvertisement::ErrorCode)> const&)' Original issue's description: > Add CPP API for BLE advertisments. > > This CL adds the new classes, changes to existing classes and tests for adding > the CPP API for LE advertisements. The design for this is available at > http://go/chrome-ble-advertising. > > R=armansito@chromium.org, jamuraa@chromium.org > BUG=466375 > > Committed: https://crrev.com/c96da18077ef4b5ab28cb8b2684cd84386075e5a > Cr-Commit-Position: refs/heads/master@{#327128} TBR=armansito@chromium.org,jamuraa@chromium.org,scheib@chromium.org,rkc@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=466375 Committed: https://crrev.com/28bc6bec94e67f23a6a9a16490e6bdf721cf6b27 Cr-Commit-Position: refs/heads/master@{#327155}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -685 lines) Patch
M chromeos/dbus/bluetooth_le_advertisement_service_provider.h View 2 chunks +1 line, -7 lines 0 comments Download
M chromeos/dbus/bluetooth_le_advertisement_service_provider.cc View 5 chunks +10 lines, -6 lines 0 comments Download
M chromeos/dbus/fake_bluetooth_le_advertisement_service_provider.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chromeos/dbus/fake_bluetooth_le_advertisement_service_provider.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chromeos/dbus/fake_bluetooth_le_advertising_manager_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/fake_bluetooth_le_advertising_manager_client.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M device/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M device/bluetooth/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M device/bluetooth/bluetooth.gyp View 1 chunk +0 lines, -4 lines 0 comments Download
M device/bluetooth/bluetooth_adapter.h View 3 chunks +0 lines, -13 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_chromeos.h View 1 chunk +0 lines, -5 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_chromeos.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_mac.h View 1 chunk +0 lines, -4 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_mac.mm View 1 chunk +0 lines, -8 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_win.h View 1 chunk +0 lines, -4 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_win.cc View 1 chunk +0 lines, -8 lines 0 comments Download
D device/bluetooth/bluetooth_advertisement.h View 1 chunk +0 lines, -137 lines 0 comments Download
D device/bluetooth/bluetooth_advertisement.cc View 1 chunk +0 lines, -37 lines 0 comments Download
D device/bluetooth/bluetooth_advertisement_chromeos.h View 1 chunk +0 lines, -59 lines 0 comments Download
D device/bluetooth/bluetooth_advertisement_chromeos.cc View 1 chunk +0 lines, -115 lines 0 comments Download
D device/bluetooth/bluetooth_advertisement_chromeos_unittest.cc View 1 chunk +0 lines, -242 lines 0 comments Download
M device/bluetooth/test/mock_bluetooth_adapter.h View 1 chunk +0 lines, -4 lines 0 comments Download
M device/bluetooth/test/mock_bluetooth_adapter.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M device/device_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
spang
Created Revert of Add CPP API for BLE advertisments.
5 years, 8 months ago (2015-04-27 22:15:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111563002/1
5 years, 8 months ago (2015-04-27 22:17:00 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-27 22:18:28 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/28bc6bec94e67f23a6a9a16490e6bdf721cf6b27 Cr-Commit-Position: refs/heads/master@{#327155}
5 years, 8 months ago (2015-04-27 22:19:17 UTC) #4
rkc
5 years, 7 months ago (2015-04-28 17:27:10 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1108403002/ by rkc@chromium.org.

The reason for reverting is: Can't seem to find any bots this was failing on.
Trybots on the original CL that had component=shared_library are working fine
and locally it builds fine too..

Powered by Google App Engine
This is Rietveld 408576698