Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2513)

Unified Diff: net/socket/ssl_client_socket.h

Issue 1111553002: Unvirtual and inline SSLClientSocket setters. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: missed a field Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/socket/ssl_client_socket.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/ssl_client_socket.h
diff --git a/net/socket/ssl_client_socket.h b/net/socket/ssl_client_socket.h
index 9b768daa872b1ce783d0239ac5fa045add97ed7e..cb5e5fbe4c8e15e62eb253f77787e0a3704508f9 100644
--- a/net/socket/ssl_client_socket.h
+++ b/net/socket/ssl_client_socket.h
@@ -125,18 +125,24 @@ class NET_EXPORT SSLClientSocket : public SSLSocket {
// cryptographic implementation.
static uint16 GetMaxSupportedSSLVersion();
- void set_negotiation_extension(SSLNegotiationExtension negotiation_extension);
-
// Returns the ChannelIDService used by this socket, or NULL if
// channel ids are not supported.
virtual ChannelIDService* GetChannelIDService() const = 0;
protected:
- virtual void set_signed_cert_timestamps_received(
- bool signed_cert_timestamps_received);
+ void set_negotiation_extension(
+ SSLNegotiationExtension negotiation_extension) {
+ negotiation_extension_ = negotiation_extension;
+ }
+
+ void set_signed_cert_timestamps_received(
+ bool signed_cert_timestamps_received) {
+ signed_cert_timestamps_received_ = signed_cert_timestamps_received;
+ }
- virtual void set_stapled_ocsp_response_received(
- bool stapled_ocsp_response_received);
+ void set_stapled_ocsp_response_received(bool stapled_ocsp_response_received) {
+ stapled_ocsp_response_received_ = stapled_ocsp_response_received;
+ }
// Record which TLS extension was used to negotiate protocol and protocol
// chosen in a UMA histogram.
@@ -192,8 +198,6 @@ class NET_EXPORT SSLClientSocket : public SSLSocket {
FRIEND_TEST_ALL_PREFIXES(SSLClientSocketTest,
VerifyServerChainProperlyOrdered);
- // Protocol that we negotiated with the server.
- NextProto protocol_negotiated_;
// True if SCTs were received via a TLS extension.
bool signed_cert_timestamps_received_;
// True if a stapled OCSP response was received.
« no previous file with comments | « no previous file | net/socket/ssl_client_socket.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698