Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1111543003: Fix --force-device-scale-factor on Mac (Closed)

Created:
5 years, 8 months ago by enne (OOO)
Modified:
5 years, 8 months ago
Reviewers:
oshima, ccameron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix --force-device-scale-factor on Mac Previously, Display would read the device scale factor from the command line in its ctor, but then screen would clobber it. This meant that the force device scale factor command line flag was silently ignored. R=oshima@chromium.org,ccameron@chromium.org Committed: https://crrev.com/a9d8ec8211082f6063f1f9188d7585fe05362f58 Cr-Commit-Position: refs/heads/master@{#327211}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M ui/gfx/screen_mac.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
enne (OOO)
5 years, 8 months ago (2015-04-28 00:16:10 UTC) #1
ccameron
lgtm -- thanks!
5 years, 8 months ago (2015-04-28 00:18:28 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111543003/1
5 years, 8 months ago (2015-04-28 00:33:23 UTC) #4
oshima
lgtm
5 years, 8 months ago (2015-04-28 00:46:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111543003/1
5 years, 8 months ago (2015-04-28 01:16:56 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-28 01:19:24 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-28 01:21:16 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a9d8ec8211082f6063f1f9188d7585fe05362f58
Cr-Commit-Position: refs/heads/master@{#327211}

Powered by Google App Engine
This is Rietveld 408576698