Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Unified Diff: media/filters/pipeline_integration_test.cc

Issue 111153003: FFmpeg fixups for M33 roll. Now with more Opus! (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add DEPS. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« media/filters/opus_audio_decoder.cc ('K') | « media/filters/opus_audio_decoder.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/pipeline_integration_test.cc
diff --git a/media/filters/pipeline_integration_test.cc b/media/filters/pipeline_integration_test.cc
index 06566ec843a85b1000625486cbd93c6e495d35f7..70688cbcfaceb0a4451441803d96d8939dd36cd7 100644
--- a/media/filters/pipeline_integration_test.cc
+++ b/media/filters/pipeline_integration_test.cc
@@ -60,7 +60,6 @@ const int kAppendTimeMs = kAppendTimeSec * 1000;
const int k320WebMFileDurationMs = 2737;
const int k640WebMFileDurationMs = 2763;
const int kOpusEndTrimmingWebMFileDurationMs = 2771;
-const uint32 kOpusEndTrimmingWebMFileAudioBytes = 528676;
const int kVP9WebMFileDurationMs = 2735;
const int kVP8AWebMFileDurationMs = 2700;
@@ -564,8 +563,6 @@ TEST_F(PipelineIntegrationTest, BasicPlayback_MediaSource_Opus_WebM) {
Play();
ASSERT_TRUE(WaitUntilOnEnded());
- EXPECT_EQ(kOpusEndTrimmingWebMFileAudioBytes,
- pipeline_->GetStatistics().audio_bytes_decoded);
source.Abort();
Stop();
}
@@ -1060,10 +1057,12 @@ TEST_F(PipelineIntegrationTest, ChunkDemuxerAbortRead_VideoOnly) {
TEST_F(PipelineIntegrationTest, BasicPlayback_AudioOnly_Opus_WebM) {
ASSERT_TRUE(Start(GetTestDataFilePath("bear-opus-end-trimming.webm"),
PIPELINE_OK));
+ EXPECT_EQ(1u, pipeline_->GetBufferedTimeRanges().size());
+ EXPECT_EQ(0, pipeline_->GetBufferedTimeRanges().start(0).InMilliseconds());
+ EXPECT_EQ(kOpusEndTrimmingWebMFileDurationMs,
+ pipeline_->GetBufferedTimeRanges().end(0).InMilliseconds());
vignesh 2013/12/11 20:10:18 Could you please verify manually if this test pass
DaleCurtis 2013/12/11 22:19:36 End trimming works, but start trimming appears bro
Play();
ASSERT_TRUE(WaitUntilOnEnded());
- EXPECT_EQ(kOpusEndTrimmingWebMFileAudioBytes,
- pipeline_->GetStatistics().audio_bytes_decoded);
}
// Verify that VP9 video in WebM containers can be played back.
« media/filters/opus_audio_decoder.cc ('K') | « media/filters/opus_audio_decoder.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698