Issue 1111513003: Simplify parseHTMLAreaCoordinate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1111513003: Simplify parseHTMLAreaCoordinate (Closed)

Created:
5 years, 8 months ago by rwlbuis

Modified:
5 years, 8 months ago

Reviewers:
pdr.

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Simplify parseHTMLAreaCoordinate Simplify parseHTMLAreaCoordinate by not using the "ok" parameter. charactersToIntStrict is guaranteed to return 0 if an error occurred, i.e. if ok would be false. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194558

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -5 lines)			Patch
	M	Source/platform/Length.cpp	View		1 chunk	+1 line, -5 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

rwlbuis

PTAL. I'd ask jchaffraix since he last touched this code but he is OOO.

5 years, 8 months ago (2015-04-27 23:51:44 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111513003/1

5 years, 8 months ago (2015-04-28 00:13:17 UTC) #5

commit-bot: I haz the power

5 years, 8 months ago (2015-04-28 01:21:46 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194558

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages