Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 1111463002: Updated the documention for webview.back() and webview.forward() to reflect that they now have call… (Closed)

Created:
5 years, 8 months ago by paulmeyer
Modified:
5 years, 8 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updated the documention for webview.back() and webview.forward() to reflect that they now have callbacks. BUG=481594 Committed: https://crrev.com/646220571a8e95f80110075c3fe5947a6959966c Cr-Commit-Position: refs/heads/master@{#327121}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -2 lines) Patch
M chrome/common/extensions/api/webview_tag.json View 1 3 chunks +32 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
paulmeyer
+lazyboy@
5 years, 8 months ago (2015-04-27 18:42:05 UTC) #2
lazyboy
https://codereview.chromium.org/1111463002/diff/1/chrome/common/extensions/api/webview_tag.json File chrome/common/extensions/api/webview_tag.json (right): https://codereview.chromium.org/1111463002/diff/1/chrome/common/extensions/api/webview_tag.json#newcode345 chrome/common/extensions/api/webview_tag.json:345: "name": "callback", This also needs a "description", saying what ...
5 years, 8 months ago (2015-04-27 18:50:54 UTC) #3
paulmeyer
ptal. https://codereview.chromium.org/1111463002/diff/1/chrome/common/extensions/api/webview_tag.json File chrome/common/extensions/api/webview_tag.json (right): https://codereview.chromium.org/1111463002/diff/1/chrome/common/extensions/api/webview_tag.json#newcode345 chrome/common/extensions/api/webview_tag.json:345: "name": "callback", On 2015/04/27 18:50:54, lazyboy wrote: > ...
5 years, 8 months ago (2015-04-27 19:35:18 UTC) #4
lazyboy
LGTM thanks.
5 years, 8 months ago (2015-04-27 19:46:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111463002/20001
5 years, 8 months ago (2015-04-27 19:48:06 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-27 21:15:36 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 21:16:36 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/646220571a8e95f80110075c3fe5947a6959966c
Cr-Commit-Position: refs/heads/master@{#327121}

Powered by Google App Engine
This is Rietveld 408576698