Refactor the code distributing width to columns in auto layout tables.

Source/core/layout/TableLayoutAlgorithmAuto.h

Index: Source/core/layout/TableLayoutAlgorithmAuto.h
diff --git a/Source/core/layout/TableLayoutAlgorithmAuto.h b/Source/core/layout/TableLayoutAlgorithmAuto.h
index 079d80c34dc6294a93c8a319981dfaaa76e46de4..47bbb00a73964a35c741eeda591257581a24aed7 100644
--- a/Source/core/layout/TableLayoutAlgorithmAuto.h
+++ b/Source/core/layout/TableLayoutAlgorithmAuto.h
@@ -31,6 +31,22 @@ namespace blink {
 class LayoutTable;
 class LayoutTableCell;
 
+enum LimitToCells {

[mstensho (USE GERRIT), 2015/04/28 21:53:13]

Maybe "CellsToProcess" instead?

[mstensho (USE GERRIT), 2015/05/04 20:42:48]

Acknowledged.

+    AllCells,
+    NonEmptyCells
+};
+
+enum DistributionMode {
+    ExtraWidth,
+    InitialWidth,
+    LeftOverWidth

[mstensho (USE GERRIT), 2015/04/28 21:53:13]

Shouldn't that be "LeftoverWidth"? "Leftover" is a dictionary word.

[mstensho (USE GERRIT), 2015/05/04 20:42:47]

Acknowledged.

+};
+
+enum DistributionDirection {
+    StartToEnd,
+    EndToStart
+};
+
 class TableLayoutAlgorithmAuto final : public TableLayoutAlgorithm {
 public:
     TableLayoutAlgorithmAuto(LayoutTable*);
@@ -46,7 +62,8 @@ private:
     void recalcColumn(unsigned effCol);
 
     int calcEffectiveLogicalWidth();
-    void shrinkCellWidth(const LengthType&, int& available);
+    void shrinkColumnWidth(const LengthType&, int& available);
+    void distributeWidthToColumns(const LengthType&, int& available, int total, LimitToCells = AllCells, DistributionMode = ExtraWidth, DistributionDirection = StartToEnd);

[mstensho (USE GERRIT), 2015/04/28 21:53:13]

Just wondering if it should be called distributeExtraWidthToColumns() instead?
This is what takes place after all desired widths have been satisfied and we
still have more space to distribute.

Also, I think the default values are somewhat non-intuitive, and I think it
would help readability at the call sites to just drop them.

[mstensho (USE GERRIT), 2015/05/04 20:42:48]

You explained why this would be a bad move. So the current name is fine.
What I meant to suggest was to remove all default parameter values, like this:

void distributeWidthToColumns(const LengthType&, int& available, int total,
LimitToCells, DistributionMode, DistributionDirection)

... but see my suggestion regarding using templates.

 
     void insertSpanCell(LayoutTableCell*);