Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1111433002: Revert of Suppress data races in SkEventTracer (Closed)

Created:
5 years, 8 months ago by mtklein
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Suppress data races in SkEventTracer (patchset #1 id:1 of https://codereview.chromium.org/1081863003/) Reason for revert: I think this is fixed. Original issue's description: > Suppress data races in SkEventTracer > > BUG=437044 > TBR=mtklein@chromium.org > > Committed: https://crrev.com/f0a9e71e6ad0b13397d45afeeeba7c0ced15b570 > Cr-Commit-Position: refs/heads/master@{#326024} TBR=mtklein@chromium.org,glider@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=437044 Committed: https://crrev.com/bc743cc147868ef8a21db6e2d8bb4c6386b96689 Cr-Commit-Position: refs/heads/master@{#327102}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M build/sanitizers/tsan_suppressions.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
mtklein
Created Revert of Suppress data races in SkEventTracer
5 years, 8 months ago (2015-04-27 17:49:47 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111433002/1
5 years, 8 months ago (2015-04-27 17:51:08 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-27 17:52:37 UTC) #5
Alexander Potapenko
lgtm
5 years, 8 months ago (2015-04-27 18:02:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111433002/1
5 years, 8 months ago (2015-04-27 19:29:56 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-27 19:30:51 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 19:31:45 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc743cc147868ef8a21db6e2d8bb4c6386b96689
Cr-Commit-Position: refs/heads/master@{#327102}

Powered by Google App Engine
This is Rietveld 408576698