cc: Gather and lock/unlock SkDiscardablePixelRefs instead of skia::LazyPixelRefs.

skia/ext/discardable_pixel_ref_utils.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef SKIA_EXT_LAZY_PIXEL_REF_UTILS_H_
-#define SKIA_EXT_LAZY_PIXEL_REF_UTILS_H_
+#ifndef SKIA_EXT_DISCARDABLE_PIXEL_REF_UTILS_H_
+#define SKIA_EXT_DISCARDABLE_PIXEL_REF_UTILS_H_
 
 #include <vector>
 
 #include "SkPicture.h"
 #include "SkRect.h"
 
 namespace skia {
 
-class LazyPixelRef;
-class SK_API LazyPixelRefUtils {
+class SK_API DiscardablePixelRefUtils {

[vmpstr, 2013/12/20 17:41:06]

What do you think of naming this PixelRefUtils and having GatherPixelRefs be
renamed to GatherDiscardablePixelRefs?

I think that would better reflect what we're doing? And in the future, if we
rename discardable to whatever else, the class name can stay the same :)

The only draw back is that "PixelRefUtils" might be a bit too generic, and
possibly already used in skia or somewhere else.

[reveman, 2013/12/20 18:22:19]

Good idea. Done.

  public:
 
-  struct PositionLazyPixelRef {
-    skia::LazyPixelRef* lazy_pixel_ref;
+  struct PositionPixelRef {
+    SkPixelRef* pixel_ref;
     SkRect pixel_ref_rect;
   };
 
   static void GatherPixelRefs(
       SkPicture* picture,
-      std::vector<PositionLazyPixelRef>* lazy_pixel_refs);
+      std::vector<PositionPixelRef>* pixel_refs);
 };
 
-typedef std::vector<LazyPixelRefUtils::PositionLazyPixelRef> LazyPixelRefList;
+typedef std::vector<DiscardablePixelRefUtils::PositionPixelRef>
+    DiscardablePixelRefList;
 
 }  // namespace skia
 
 #endif