Issue 11114015: Revert 161542 - WebSocket test server migration on ExtensionApiTest.WebSocket (retry)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11114015: Revert 161542 - WebSocket test server migration on ExtensionApiTest.WebSocket (retry) (Closed)

Created:
8 years, 2 months ago by kochi

Modified:
8 years, 2 months ago

Reviewers:
Takashi Toyoshima

CC:
chromium-reviews, pam+watch_chromium.org, cbentzel+watch_chromium.org, mihaip-chromium-reviews_chromium.org, darin-cc_chromium.org, Aaron Boodman

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 161542 - WebSocket test server migration on ExtensionApiTest.WebSocket (retry) WebSocket test server migration from content::TestWebSocketServer to net::TestServer. This is the first change to use net::TestServer as a WebSocket test server. Other changes will follow to obsoelte content::TestWebSocketServer. BUG=137639 TEST=browser_test --gtest_filter='ExtensionApiTest.WebSocket' Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161304 Review URL: https://chromiumcodereview.appspot.com/11087027 TBR=toyoshim@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=161549

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -47 lines)			Patch
M	chrome/browser/extensions/extension_apitest.h	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_apitest.cc	View	2 chunks	+5 lines, -10 lines	0 comments	Download
M	chrome/browser/extensions/extension_websocket_apitest.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/api/test.json	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/websocket/test.js	View	2 chunks	+7 lines, -9 lines	0 comments	Download
D	net/data/websocket/echo_wsh.py	View	1 chunk	+0 lines, -18 lines	0 comments	Download
M	net/tools/testserver/testserver.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kochi

8 years, 2 months ago (2012-10-12 10:16:13 UTC) #2

Toyoshima-san,

This made Mac builders to fail on tests.
Could you take a look?
http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.6%20Tes...

Expand Messages | Collapse Messages