presubmit_support.py - Issue 11114005: implement per-file OWNERS support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: presubmit_support.py

Issue 11114005: implement per-file OWNERS support (Closed) Base URL: https://git.chromium.org/chromium/tools/depot_tools.git@master

Patch Set: change "owner" to "directive" in add_entry Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: presubmit_support.py

diff --git a/presubmit_support.py b/presubmit_support.py

index b1fdcb2fb7f1b527674650983b52a77a79154e56..0989fd1662ffea28b6bd09b4c9798711995ea4b4 100755

--- a/presubmit_support.py

+++ b/presubmit_support.py

@@ -238,6 +238,7 @@ class InputApi(object):

self.basename = os.path.basename

self.cPickle = cPickle

self.cStringIO = cStringIO

+ self.glob = glob.glob

self.json = json

self.logging = logging.getLogger('PRESUBMIT')

self.os_listdir = os.listdir

@@ -269,7 +270,7 @@ class InputApi(object):

# TODO(dpranke): figure out a list of all approved owners for a repo

# in order to be able to handle wildcard OWNERS files?

self.owners_db = owners.Database(change.RepositoryRoot(),

- fopen=file, os_path=self.os_path)

+ fopen=file, os_path=self.os_path, glob=self.glob)

self.verbose = verbose

def PresubmitLocalPath(self):