Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(15)

Issue 1111383002: [tracing] Expose memory-infra tracing infrastructure to Blink. (Closed)

Created:
5 years ago by Primiano Tucci (use gerrit)
Modified:
5 years ago
CC:
blink-reviews, dglazkov+blink, nduca
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[tracing] Expose memory-infra tracing infrastructure to Blink. Exposes the core memory-infra classes to Blink. These classes are, in the very essence, a reproposition of base::trace_event ones and keep the same semantic. The Chromium-side changes are in crrev.com/1108403006 For more documentation see the design doc: http://goo.gl/Bdyql6 BUG=480500 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194822

Patch Set 1 #

Total comments: 4

Patch Set 2 : Wrapping at 80 cols #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -0 lines) Patch
M public/platform/Platform.h View 1 2 chunks +10 lines, -0 lines 0 comments Download
A public/platform/WebMemoryAllocatorDump.h View 1 1 chunk +32 lines, -0 lines 0 comments Download
A public/platform/WebMemoryDumpProvider.h View 1 1 chunk +28 lines, -0 lines 0 comments Download
A public/platform/WebProcessMemoryDump.h View 1 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Primiano Tucci (use gerrit)
Hello! Here it is all the dumper plumbing as agreed. Design doc with example here: ...
5 years ago (2015-04-29 22:11:58 UTC) #2
haraken
The API looks good in terms of the memory-infra design (I'm not an API owner). ...
5 years ago (2015-04-30 01:45:49 UTC) #3
Primiano Tucci (use gerrit)
+jochen as /public OWNER Fixed comments. I am working on the tests right now, but ...
5 years ago (2015-04-30 09:07:43 UTC) #5
Primiano Tucci (use gerrit)
+pdr, could you PTAL to this? This is to expose go/memory-infra to blink and enable ...
5 years ago (2015-04-30 16:57:02 UTC) #7
dsinclair
lgtm
5 years ago (2015-05-01 16:53:11 UTC) #9
dsinclair
5 years ago (2015-05-01 16:53:24 UTC) #11
Rick Byers
public/ RS LGTM (given the design review that's already occurred here, on the doc, and ...
5 years ago (2015-05-01 17:09:28 UTC) #13
Primiano Tucci (use gerrit)
On 2015/04/30 01:45:49, haraken wrote: > The API looks good in terms of the memory-infra ...
5 years ago (2015-05-01 17:12:32 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111383002/20001
5 years ago (2015-05-01 17:12:57 UTC) #16
commit-bot: I haz the power
5 years ago (2015-05-01 18:45:12 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194822

Powered by Google App Engine
This is Rietveld 408576698