Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1111333003: Disable flaky test, ExtensionWindowCreateTest.AcceptState on mac (Closed)

Created:
5 years, 7 months ago by limasdf
Modified:
5 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable flaky test, ExtensionWindowCreateTest.AcceptState for mac fullscreen state test is flaky on mac. disable it. This test does create window with fullscreen state. BUG=482433 Committed: https://crrev.com/b6f3ec3a0951c65c8c39f261c58a9ca03bcd80a0 Cr-Commit-Position: refs/heads/master@{#327526}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M chrome/browser/extensions/api/tabs/tabs_test.cc View 1 chunk +11 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
limasdf
Sorry about this issue. disable for temporarily. I'll find another way to prevent flaky.
5 years, 7 months ago (2015-04-29 16:41:42 UTC) #2
not at google - send to devlin
lgtm
5 years, 7 months ago (2015-04-29 17:10:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111333003/1
5 years, 7 months ago (2015-04-29 17:10:30 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 18:18:45 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 18:19:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b6f3ec3a0951c65c8c39f261c58a9ca03bcd80a0
Cr-Commit-Position: refs/heads/master@{#327526}

Powered by Google App Engine
This is Rietveld 408576698