Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1111323003: Reland: [turbofan] add MachineType to AllocatedOperand (Closed)

Created:
5 years, 7 months ago by dcarney
Modified:
5 years, 7 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland: [turbofan] add MachineType to AllocatedOperand - allows the optimization of emitted gap move code since the representation of the value in the register is known - necessary preparation for vector register allocation - prepare for slot sharing for any value of the same byte width TBR=jarin@chromium.org BUG= Committed: https://crrev.com/81345f1a2cdceaee8c891fc7512ae671f171308e Cr-Commit-Position: refs/heads/master@{#28140}

Patch Set 1 : original patch #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+522 lines, -347 lines) Patch
M src/compiler/frame.h View 3 chunks +7 lines, -12 lines 0 comments Download
M src/compiler/gap-resolver.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/instruction.h View 13 chunks +94 lines, -32 lines 0 comments Download
M src/compiler/instruction.cc View 5 chunks +77 lines, -27 lines 0 comments Download
M src/compiler/instruction-selector.h View 1 chunk +5 lines, -12 lines 0 comments Download
M src/compiler/instruction-selector.cc View 5 chunks +70 lines, -123 lines 0 comments Download
M src/compiler/instruction-selector-impl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/move-optimizer.cc View 3 chunks +18 lines, -5 lines 0 comments Download
M src/compiler/register-allocator.h View 13 chunks +29 lines, -20 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 31 chunks +167 lines, -84 lines 0 comments Download
M src/compiler/register-allocator-verifier.cc View 5 chunks +13 lines, -12 lines 0 comments Download
M test/cctest/compiler/test-gap-resolver.cc View 3 chunks +27 lines, -6 lines 0 comments Download
M test/cctest/compiler/test-instruction.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/compiler/test-jump-threading.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/unittests/compiler/move-optimizer-unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111323003/20001
5 years, 7 months ago (2015-04-29 18:40:29 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-04-29 19:36:21 UTC) #4
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 19:36:43 UTC) #5
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/81345f1a2cdceaee8c891fc7512ae671f171308e
Cr-Commit-Position: refs/heads/master@{#28140}

Powered by Google App Engine
This is Rietveld 408576698