Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1111323002: Attempt to deflake svg/custom/js-late-{clipPath,gradient}-and-...svg (Closed)

Created:
5 years, 7 months ago by fs
Modified:
5 years, 7 months ago
Reviewers:
pdr.
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Attempt to deflake svg/custom/js-late-{clipPath,gradient}-and-...svg Set testIsAsync to true and call finishRepaintTest(). Use runAfterDisplay instead of setTimeout(..., 0); Mark for rebaselining because the current baselines are a bit rotten. BUG=353301, 302529 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194720

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -16 lines) Patch
M LayoutTests/TestExpectations View 2 chunks +6 lines, -2 lines 0 comments Download
M LayoutTests/svg/custom/js-late-clipPath-and-object-creation.svg View 3 chunks +6 lines, -7 lines 0 comments Download
M LayoutTests/svg/custom/js-late-gradient-and-object-creation.svg View 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fs
5 years, 7 months ago (2015-04-29 16:11:01 UTC) #2
pdr.
LGTM Feel free to rebaseline this manually or with the rebaseline bot.
5 years, 7 months ago (2015-04-29 19:47:16 UTC) #3
fs
On 2015/04/29 19:47:16, pdr wrote: > LGTM > > Feel free to rebaseline this manually ...
5 years, 7 months ago (2015-04-30 08:21:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111323002/1
5 years, 7 months ago (2015-04-30 08:22:53 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 10:07:31 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194720

Powered by Google App Engine
This is Rietveld 408576698