Issue 1111273008: Removing unnecessary creation of local variable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1111273008: Removing unnecessary creation of local variable (Closed)

Created:
5 years, 7 months ago by ashish1.a

Modified:
5 years, 7 months ago

Reviewers:
haraken

CC:
blink-reviews, blink-reviews-events_chromium.org, dglazkov+blink, eae+blinkwatch

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Removing unnecessary creation of local variable Removing unnecessary creation of local variable in file Source/core/page/EventHandler.cpp BUG=NONE Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194724

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	Source/core/page/EventHandler.cpp	View		2 chunks	+1 line, -2 lines	0 comments	Download

Total messages: 6 (2 generated)

haraken

LGTM for this change, but I'd suggest stopping this kind of small refactoring that don't ...

5 years, 7 months ago (2015-04-30 07:12:34 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111273008/1

5 years, 7 months ago (2015-04-30 07:56:52 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-04-30 10:37:22 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194724