Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1111273003: Create SP enabled SKPs from only the top_25_smooth page set (Closed)

Created:
5 years, 7 months ago by rmistry
Modified:
5 years, 7 months ago
Reviewers:
jcgregorio, borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Create SP enabled SKPs from only the top_25_smooth page set. Context is here: https://code.google.com/p/skia/issues/detail?id=3763#c14 BUG=skia:3763 NOTRY=true Committed: https://skia.googlesource.com/skia/+/385e88cc16ed872ece98471513764c8e7ca1a26c

Patch Set 1 : Initial upload #

Patch Set 2 : Cleanup #

Patch Set 3 : Remove key_mobile_sites #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M tools/skp/recreate_skps.py View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
rmistry
5 years, 7 months ago (2015-04-29 14:19:01 UTC) #2
borenet
LGTM but I'm worried about taking up a lot of disk space and transfer time.
5 years, 7 months ago (2015-04-29 14:22:02 UTC) #3
rmistry
On 2015/04/29 14:22:02, borenet wrote: > LGTM but I'm worried about taking up a lot ...
5 years, 7 months ago (2015-04-29 14:24:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111273003/40001
5 years, 7 months ago (2015-04-29 14:26:24 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 14:26:37 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/385e88cc16ed872ece98471513764c8e7ca1a26c

Powered by Google App Engine
This is Rietveld 408576698