Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1111233002: Use Local<> instead of Handle<> in public/* (Closed)

Created:
5 years, 7 months ago by deepak.s
Modified:
5 years, 7 months ago
Reviewers:
haraken, tkent
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use Local<> instead of Handle<> in public/* Replace Handle<> with Local<> BUG=424445 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194682

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M public/web/WebDOMActivityLogger.h View 1 chunk +2 lines, -2 lines 0 comments Download
M public/web/WebFrameClient.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
deepak.s
PTAL? Thanks!
5 years, 7 months ago (2015-04-29 11:00:29 UTC) #2
haraken
Don't we need to update the chromium source code that overrides these functions as well? ...
5 years, 7 months ago (2015-04-29 11:28:45 UTC) #3
deepak.s
On 2015/04/29 11:28:45, haraken wrote: > Don't we need to update the chromium source code ...
5 years, 7 months ago (2015-04-29 11:30:52 UTC) #4
haraken
On 2015/04/29 11:30:52, deepak.s wrote: > On 2015/04/29 11:28:45, haraken wrote: > > Don't we ...
5 years, 7 months ago (2015-04-29 11:52:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111233002/1
5 years, 7 months ago (2015-04-29 11:53:53 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/32338)
5 years, 7 months ago (2015-04-29 11:59:43 UTC) #9
deepak.s
Suggested owner for public/* ?
5 years, 7 months ago (2015-04-29 12:03:21 UTC) #10
haraken
+tkent for an owner review.
5 years, 7 months ago (2015-04-29 12:03:57 UTC) #12
tkent
lgtm
5 years, 7 months ago (2015-04-29 22:45:21 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111233002/1
5 years, 7 months ago (2015-04-29 22:46:08 UTC) #15
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 00:21:47 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194682

Powered by Google App Engine
This is Rietveld 408576698