lib/source_map_stack_trace.dart - Issue 1111223003: Prefer "dart:" URLs to "package:" URLs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/source_map_stack_trace.dart

Issue 1111223003: Prefer "dart:" URLs to "package:" URLs. (Closed) Base URL: git@github.com:dart-lang/source_map_stack_trace.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/source_map_stack_trace.dart

diff --git a/lib/source_map_stack_trace.dart b/lib/source_map_stack_trace.dart

index 41072e4fa70cbedadd697e055f115dddfc89ffa6..76ad41aff99ec39d07f7f9ed0991e2a1ce140873 100644

--- a/lib/source_map_stack_trace.dart

+++ b/lib/source_map_stack_trace.dart

@@ -61,11 +61,11 @@ StackTrace mapStackTrace(Mapping sourceMap, StackTrace stackTrace,

if (span == null) return null;

var sourceUrl = span.sourceUrl.toString();

- if (packageRoot != null && p.url.isWithin(packageRoot, sourceUrl)) {

+ if (sdkRoot != null && p.url.isWithin(sdkLib, sourceUrl)) {

+ sourceUrl = "dart:" + p.url.relative(sourceUrl, from: sdkLib);

+ } else if (packageRoot != null && p.url.isWithin(packageRoot, sourceUrl)) {

sourceUrl = "package:" +

p.url.relative(sourceUrl, from: packageRoot);

- } else if (sdkRoot != null && p.url.isWithin(sdkLib, sourceUrl)) {

- sourceUrl = "dart:" + p.url.relative(sourceUrl, from: sdkLib);

}

return new Frame(

« no previous file with comments | « CHANGELOG.md ('k') | pubspec.yaml » ('j') | no next file with comments »