Invalidate ancestor resources in when relative lengths change

Source/core/svg/SVGElement.cpp

 /*
  * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2008 Rob Buis <buis@kde.org>
  * Copyright (C) 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Alp Toker <alp@atoker.com>
  * Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 405 matching lines @@
     ASSERT(!m_inRelativeLengthClientsInvalidation);
 #if ENABLE(ASSERT)
     TemporaryChange<bool> inRelativeLengthClientsInvalidationChange(m_inRelativeLengthClientsInvalidation, true);
 #endif
 
     LayoutObject* renderer = this->layoutObject();
     if (renderer && selfHasRelativeLengths()) {
         if (renderer->isSVGResourceContainer())
             toLayoutSVGResourceContainer(renderer)->invalidateCacheAndMarkForLayout(layoutScope);
         else
-            renderer->setNeedsLayoutAndFullPaintInvalidation(LayoutInvalidationReason::Unknown, MarkContainerChain, layoutScope);

[fs, 2015/04/30 13:36:47]

So Unknown -> SvgResourceInvalidated; bad -> weird. Having
SvgResourceInvalidated where it is is weird too though. I'll look into
refactoring that function a bit to unweird this a bit.

+            markForLayoutAndParentResourceInvalidation(renderer, layoutScope);
     }
 
     for (SVGElement* element : m_elementsWithRelativeLengths) {
         if (element != this)
             element->invalidateRelativeLengthClients(layoutScope);
     }
 }
 
 SVGSVGElement* SVGElement::ownerSVGElement() const
 {
@@ skipping 514 matching lines @@
 
     return svgRareData()->overrideComputedStyle(this, parentStyle);
 }
 
 bool SVGElement::hasFocusEventListeners() const
 {
     return hasEventListeners(EventTypeNames::focusin) || hasEventListeners(EventTypeNames::focusout)
         || hasEventListeners(EventTypeNames::focus) || hasEventListeners(EventTypeNames::blur);
 }
 
-void SVGElement::markForLayoutAndParentResourceInvalidation(LayoutObject* renderer)
+void SVGElement::markForLayoutAndParentResourceInvalidation(LayoutObject* renderer, SubtreeLayoutScope* layoutScope)
 {
     ASSERT(renderer);
-    LayoutSVGResourceContainer::markForLayoutAndParentResourceInvalidation(renderer, true);
+    const bool needsLayout = true;
+    LayoutSVGResourceContainer::markForLayoutAndParentResourceInvalidation(renderer, needsLayout, layoutScope);
 }
 
 void SVGElement::invalidateInstances()
 {
     if (instanceUpdatesBlocked())
         return;
 
     const WillBeHeapHashSet<RawPtrWillBeWeakMember<SVGElement>>& set = instancesForElement();
     if (set.isEmpty())
         return;
@@ skipping 209 matching lines @@
     Element::trace(visitor);
 }
 
 const AtomicString& SVGElement::eventParameterName()
 {
     DEFINE_STATIC_LOCAL(const AtomicString, evtString, ("evt", AtomicString::ConstructFromLiteral));
     return evtString;
 }
 
 } // namespace blink