Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 1111203002: Use of base::StringPairs appropriately in simple_backend_impl (Closed)

Created:
5 years, 7 months ago by payal.pandey
Modified:
5 years, 7 months ago
Reviewers:
pasko, eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use of base::StringPairs appropriately in simple_backend_impl Bescause base/strings/string_split.h defines: typedef std::vector<std::pair<std::string, std::string> > StringPairs; BUG=412250 Committed: https://crrev.com/cca651ab3b8bdc2d729c34f9dd3988abd53ca81c Cr-Commit-Position: refs/heads/master@{#327686}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M net/disk_cache/simple/simple_backend_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/disk_cache/simple/simple_backend_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
payal.pandey
Please have a look, Thanks.
5 years, 7 months ago (2015-04-29 10:01:23 UTC) #2
eroman
lgtm
5 years, 7 months ago (2015-04-29 19:32:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111203002/1
5 years, 7 months ago (2015-04-30 06:33:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111203002/1
5 years, 7 months ago (2015-04-30 09:04:40 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-30 09:14:05 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cca651ab3b8bdc2d729c34f9dd3988abd53ca81c Cr-Commit-Position: refs/heads/master@{#327686}
5 years, 7 months ago (2015-04-30 09:14:57 UTC) #11
pasko
5 years, 7 months ago (2015-04-30 09:29:27 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698