Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1111193002: [Upstream] Force instantiation of BSKSF during unit tests (Closed)

Created:
5 years, 7 months ago by sdefresne
Modified:
5 years, 7 months ago
Reviewers:
droger
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Upstream] Force instantiation of BSKSF during unit tests Call EnsureBrowserStateKeyedServiceFactoriesBuilt() during initialisation of "chrome_ios_unittests" to ensure the BSKSF are correctly registered against the DependencyManager before launching the tests. Call ios::RegisterPathProvider() before running the tests so that they can use the iOS specific paths by name. BUG=468694 R=droger@chromium.org Committed: https://crrev.com/b28a28e9dab905b80853424ec344aa1667b06285 Cr-Commit-Position: refs/heads/master@{#327461}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -0 lines) Patch
A ios/chrome/browser/browser_state/browser_state_keyed_service_factories.h View 1 chunk +13 lines, -0 lines 0 comments Download
A ios/chrome/browser/browser_state/browser_state_keyed_service_factories.mm View 1 chunk +24 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/test/ios_chrome_unit_test_suite.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
sdefresne
5 years, 7 months ago (2015-04-29 08:48:25 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111193002/1
5 years, 7 months ago (2015-04-29 08:49:01 UTC) #3
droger
lgtm
5 years, 7 months ago (2015-04-29 09:00:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111193002/1
5 years, 7 months ago (2015-04-29 09:03:24 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 09:55:15 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 09:56:08 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b28a28e9dab905b80853424ec344aa1667b06285
Cr-Commit-Position: refs/heads/master@{#327461}

Powered by Google App Engine
This is Rietveld 408576698