Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1111183008: [bindings] Make interface template simplified for getter/setter/deleter while using CallWith=Script… (Closed)

Created:
5 years, 7 months ago by vivekg_samsung
Modified:
5 years, 7 months ago
Reviewers:
haraken, vivekg
CC:
vivekg, arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[bindings] Make interface template simplified for getter/setter/deleter while using CallWith=ScriptState. R=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194709

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M Source/bindings/templates/interface.cpp View 3 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
vivekg
Forgot this earlier. PTAL, thanks!
5 years, 7 months ago (2015-04-30 05:36:28 UTC) #2
haraken
LGTM
5 years, 7 months ago (2015-04-30 05:48:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111183008/1
5 years, 7 months ago (2015-04-30 05:49:10 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 07:48:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194709

Powered by Google App Engine
This is Rietveld 408576698