Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1111173002: Removing blink::prefix (Closed)

Created:
5 years, 7 months ago by a.berwal
Modified:
5 years, 7 months ago
Reviewers:
haraken, tkent
CC:
blink-reviews, shans, eae+blinkwatch, fs, Mike Lawther (Google), apavlov+blink_chromium.org, kinuko+worker_chromium.org, rjwright, aandrey+blink_chromium.org, pdr+svgwatchlist_chromium.org, falken, caseq+blink_chromium.org, Steve Block, pfeldman+blink_chromium.org, yurys+blink_chromium.org, Timothy Loh, dstockwell, dglazkov+blink, gavinp+loader_chromium.org, devtools-reviews_chromium.org, gyuyoung2, rwlbuis, Eric Willigers, kenneth.christiansen, loislo+blink_chromium.org, Yoav Weiss, lushnikov+blink_chromium.org, krit, darktears, Nate Chapin, Stephen Chennney, tyoshino+watch_chromium.org, gavinp+prerender_chromium.org, blink-reviews-animation_chromium.org, kouhei+svg_chromium.org, blink-layers+watch_chromium.org, blink-reviews-events_chromium.org, ed+blinkwatch_opera.com, f(malita), horo+watch_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Removing blink::prefix Removing blink::prefix in Source/core/* whereever it is not needed. BUG=477256 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194653

Patch Set 1 #

Patch Set 2 : rebasing #

Total comments: 1

Patch Set 3 : Incorporating Review Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -115 lines) Patch
M Source/core/imagebitmap/ImageBitmapFactories.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/DOMPatchSupport.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InjectedScriptManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorHeapProfilerAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorLayerTreeAgent.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorResourceAgent.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorResourceContentLoader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/loader/CookieJar.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/DocumentThreadableLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/EmptyClients.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/loader/EmptyClients.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/loader/FrameLoaderClient.h View 1 2 5 chunks +11 lines, -14 lines 0 comments Download
M Source/core/loader/ImageLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/LinkLoader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/loader/PingLoader.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/loader/PingLoader.cpp View 9 chunks +10 lines, -10 lines 0 comments Download
M Source/core/loader/WorkerLoaderClientBridgeSyncHelper.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/loader/WorkerLoaderClientBridgeSyncHelper.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/loader/WorkerThreadableLoader.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/page/Chrome.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Chrome.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/ChromeClient.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/EventSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Page.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/PagePopupController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/plugins/PluginView.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/properties/SVGAnimatedProperty.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/timing/PerformanceUserTiming.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/workers/SharedWorker.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/SharedWorkerRepositoryClient.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerScriptLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerThread.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M Source/core/xmlhttprequest/XMLHttpRequest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
a.berwal
PTAL for Source/core/*
5 years, 7 months ago (2015-04-29 06:12:51 UTC) #2
haraken
LGTM https://chromiumcodereview.appspot.com/1111173002/diff/20001/Source/core/loader/FrameLoaderClient.h File Source/core/loader/FrameLoaderClient.h (right): https://chromiumcodereview.appspot.com/1111173002/diff/20001/Source/core/loader/FrameLoaderClient.h#newcode71 Source/core/loader/FrameLoaderClient.h:71: class WebApplicationCacheHostClient; Alphabetical order please.
5 years, 7 months ago (2015-04-29 11:39:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111173002/40001
5 years, 7 months ago (2015-04-29 11:47:36 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 12:58:08 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194653

Powered by Google App Engine
This is Rietveld 408576698