Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: content/browser/accessibility/browser_accessibility_win_unittest.cc

Issue 1111163002: Fixed word and line navigation in multi-line text fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_win_unittest.cc
diff --git a/content/browser/accessibility/browser_accessibility_win_unittest.cc b/content/browser/accessibility/browser_accessibility_win_unittest.cc
index 72f4450ea40d2e8c4fa9be4d2db55ecc739c0623..180bddadc9518de075723bac1d98785ae8cb842a 100644
--- a/content/browser/accessibility/browser_accessibility_win_unittest.cc
+++ b/content/browser/accessibility/browser_accessibility_win_unittest.cc
@@ -320,7 +320,7 @@ TEST_F(BrowserAccessibilityTest, TestChildrenChangeNoLeaks) {
ASSERT_EQ(0, CountedBrowserAccessibility::num_instances());
}
-TEST_F(BrowserAccessibilityTest, DISABLED_TestTextBoundaries) {
+TEST_F(BrowserAccessibilityTest, TestTextBoundaries) {
std::string text1_value = "One two three.\nFour five six.";
ui::AXNodeData text1;
@@ -378,6 +378,8 @@ TEST_F(BrowserAccessibilityTest, DISABLED_TestTextBoundaries) {
ASSERT_EQ(0, end);
text.Reset();
+ /*
dmazzoni 2015/04/29 21:49:50 Commented out on purpose? Do these assertions no l
+ // TODO(nektar): Add word_start_offsets and inline text boxes in a11y tree.
ASSERT_EQ(S_OK, text1_obj->get_textAtOffset(
1, IA2_TEXT_BOUNDARY_WORD, &start, &end, text.Receive()));
ASSERT_EQ(0, start);
@@ -398,6 +400,7 @@ TEST_F(BrowserAccessibilityTest, DISABLED_TestTextBoundaries) {
ASSERT_EQ(29, end);
ASSERT_STREQ(L"six.", text);
text.Reset();
+ */
ASSERT_EQ(S_OK, text1_obj->get_textAtOffset(
1, IA2_TEXT_BOUNDARY_LINE, &start, &end, text.Receive()));
@@ -415,8 +418,6 @@ TEST_F(BrowserAccessibilityTest, DISABLED_TestTextBoundaries) {
ASSERT_EQ(S_OK,
text1_obj->get_text(0, IA2_TEXT_OFFSET_LENGTH, text.Receive()));
- ASSERT_EQ(0, start);
- ASSERT_EQ(text1_len, end);
ASSERT_STREQ(L"One two three.\nFour five six.", text);
// Delete the manager and test that all BrowserAccessibility instances are

Powered by Google App Engine
This is Rietveld 408576698