Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 111113003: Move PageConsole to using FrameHost instead of Page (Closed)

Created:
7 years ago by eseidel
Modified:
7 years ago
Reviewers:
abarth-chromium
CC:
blink-reviews, site-isolation-reviews_chromium.org, dcheng, pfeldman
Visibility:
Public.

Description

Move PageConsole to using FrameHost instead of Page This is not a complete move. PageConsole still needs to reach through FrameHost to Page to get the mainFrame to get the main document to pass to the inspector. But otherwise it only needs chrome() which is accessible from FrameHost. BUG=305811 R=abarth@chromium.org, abarth Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164146

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M Source/core/frame/FrameHost.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/PageConsole.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/page/PageConsole.cpp View 4 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
eseidel
7 years ago (2013-12-19 06:30:04 UTC) #1
eseidel
CCing pfeldman in case he'd like to comment on the FIXME.
7 years ago (2013-12-19 06:30:44 UTC) #2
abarth-chromium
lgtm
7 years ago (2013-12-19 06:31:16 UTC) #3
eseidel
7 years ago (2013-12-19 06:46:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r164146 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698