Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 1111103002: [Telemetry] Move telemetry/examples to telemetry/experimental. (Closed)

Created:
5 years, 7 months ago by nednguyen
Modified:
5 years, 7 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Move telemetry/examples to telemetry/experimental. This is so that we can use the telemetry/examples folder for putting an examples end to end benchmark. BUG=482227 Committed: https://crrev.com/88bb32230eda97260936c965b3eb189ce93e1c48 Cr-Commit-Position: refs/heads/master@{#330629}

Patch Set 1 #

Patch Set 2 : Remove not useful files #

Total comments: 4

Patch Set 3 : Add examples/credentials_example.json back #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, -1154 lines) Patch
D tools/telemetry/examples/credentials_example.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
D tools/telemetry/examples/list_available_browsers View 1 chunk +0 lines, -23 lines 0 comments Download
D tools/telemetry/examples/measure_trace.py View 1 chunk +0 lines, -86 lines 0 comments Download
D tools/telemetry/examples/telemetry_perf_test.py View 1 chunk +0 lines, -47 lines 0 comments Download
D tools/telemetry/examples/top1k View 1 chunk +0 lines, -999 lines 0 comments Download
A + tools/telemetry/experimental/measure_trace.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/experimental/telemetry_perf_test.py View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
nednguyen
5 years, 7 months ago (2015-04-28 23:23:26 UTC) #2
aiolos (Not reviewing)
On 2015/04/28 23:23:26, nednguyen wrote: IMO, if these files aren't useful enough to be kept ...
5 years, 7 months ago (2015-04-28 23:38:22 UTC) #3
dtu
On 2015/04/28 23:38:22, aiolos wrote: > On 2015/04/28 23:23:26, nednguyen wrote: > > IMO, if ...
5 years, 7 months ago (2015-05-01 23:24:57 UTC) #4
nednguyen
Removed not very useful files and keep the useful ones: +measure_trace.py is the offline mode ...
5 years, 7 months ago (2015-05-19 15:35:00 UTC) #7
dtu
https://codereview.chromium.org/1111103002/diff/20001/tools/telemetry/examples/credentials_example.json File tools/telemetry/examples/credentials_example.json (left): https://codereview.chromium.org/1111103002/diff/20001/tools/telemetry/examples/credentials_example.json#oldcode1 tools/telemetry/examples/credentials_example.json:1: { We still need this for completeness for external ...
5 years, 7 months ago (2015-05-19 17:45:58 UTC) #8
nednguyen
https://codereview.chromium.org/1111103002/diff/20001/tools/telemetry/examples/credentials_example.json File tools/telemetry/examples/credentials_example.json (left): https://codereview.chromium.org/1111103002/diff/20001/tools/telemetry/examples/credentials_example.json#oldcode1 tools/telemetry/examples/credentials_example.json:1: { On 2015/05/19 17:45:58, dtu wrote: > We still ...
5 years, 7 months ago (2015-05-19 18:11:39 UTC) #9
dtu
On 2015/05/19 18:11:39, nednguyen wrote: > https://codereview.chromium.org/1111103002/diff/20001/tools/telemetry/examples/credentials_example.json > File tools/telemetry/examples/credentials_example.json (left): > > https://codereview.chromium.org/1111103002/diff/20001/tools/telemetry/examples/credentials_example.json#oldcode1 > ...
5 years, 7 months ago (2015-05-19 19:53:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111103002/60001
5 years, 7 months ago (2015-05-19 19:55:44 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 7 months ago (2015-05-19 22:10:52 UTC) #15
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 22:12:04 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/88bb32230eda97260936c965b3eb189ce93e1c48
Cr-Commit-Position: refs/heads/master@{#330629}

Powered by Google App Engine
This is Rietveld 408576698