Issue 11111015: Allow evals for debugger even if they are prohibited in the debugee context

Issue 11111015: Allow evals for debugger even if they are prohibited in the debugee context (Closed)

Created:
8 years, 2 months ago by yurys

Modified:
8 years, 2 months ago

Reviewers:
Michael Starzinger, pfeldman, Yang, loislo

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Allow evals for debugger even if they are prohibited in the debugee context. BUG=154733 Committed: https://code.google.com/p/v8/source/detail?r=12726

Patch Set 1 #

Total comments: 8

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+106 lines, -1 line)			Patch
	M	src/runtime.cc	View		2 chunks	+14 lines, -0 lines	2 comments	Download
	M	test/cctest/test-debug.cc	View		2 chunks	+92 lines, -1 line	6 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM (with nits). https://codereview.chromium.org/11111015/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/11111015/diff/1/src/runtime.cc#newcode11796 src/runtime.cc:11796: Remove second empty newline for readability. ...

8 years, 2 months ago (2012-10-15 09:51:25 UTC) #2

yurys

8 years, 2 months ago (2012-10-15 10:14:53 UTC) #3

https://codereview.chromium.org/11111015/diff/1/src/runtime.cc
File src/runtime.cc (right):

https://codereview.chromium.org/11111015/diff/1/src/runtime.cc#newcode11796
src/runtime.cc:11796: 
On 2012/10/15 09:51:25, Michael Starzinger wrote:
> Remove second empty newline for readability.

Done.

https://codereview.chromium.org/11111015/diff/1/test/cctest/test-debug.cc
File test/cctest/test-debug.cc (right):

https://codereview.chromium.org/11111015/diff/1/test/cctest/test-debug.cc#new...
test/cctest/test-debug.cc:2503: if (eventDetails.GetEvent() == v8::Break)
On 2012/10/15 09:51:25, Michael Starzinger wrote:
> Either on one line or add curly brackets.

Done.

https://codereview.chromium.org/11111015/diff/1/test/cctest/test-debug.cc#new...
test/cctest/test-debug.cc:2534: 
On 2012/10/15 09:51:25, Michael Starzinger wrote:
> Add second empty newline for readability.

Done.

https://codereview.chromium.org/11111015/diff/1/test/cctest/test-debug.cc#new...
test/cctest/test-debug.cc:2590: 
On 2012/10/15 09:51:25, Michael Starzinger wrote:
> Add second empty newline for readability.

Done.

Expand Messages | Collapse Messages