Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1111043002: Remove Finch flag for enabling SSL3. It's dead, Jim. (Closed)

Created:
5 years, 7 months ago by Ryan Sleevi
Modified:
5 years, 7 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Finch flag for enabling SSL3. SSL3 is dead, and while the about:flags still lives on, the fear of a need to remotely re-enable SSL3 is gone, and has passed without incident for several releases, so we can remove the supporting glue code. Also fix a style nit while here. BUG=427671 R=eroman@chromium.org Committed: https://crrev.com/b20dfab70d330734ef1681b923b076f3bb766904 Cr-Commit-Position: refs/heads/master@{#327408}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M chrome/browser/net/ssl_config_service_manager_pref.cc View 2 chunks +3 lines, -8 lines 2 comments Download

Messages

Total messages: 8 (2 generated)
Ryan Sleevi
eroman: WDYT?
5 years, 7 months ago (2015-04-28 22:31:10 UTC) #2
eroman
lgtm https://codereview.chromium.org/1111043002/diff/1/chrome/browser/net/ssl_config_service_manager_pref.cc File chrome/browser/net/ssl_config_service_manager_pref.cc (right): https://codereview.chromium.org/1111043002/diff/1/chrome/browser/net/ssl_config_service_manager_pref.cc#newcode230 chrome/browser/net/ssl_config_service_manager_pref.cc:230: registry->RegisterStringPref(prefs::kSSLVersionMin, std::string()); unrelated change?
5 years, 7 months ago (2015-04-28 22:38:13 UTC) #3
Ryan Sleevi
https://codereview.chromium.org/1111043002/diff/1/chrome/browser/net/ssl_config_service_manager_pref.cc File chrome/browser/net/ssl_config_service_manager_pref.cc (right): https://codereview.chromium.org/1111043002/diff/1/chrome/browser/net/ssl_config_service_manager_pref.cc#newcode230 chrome/browser/net/ssl_config_service_manager_pref.cc:230: registry->RegisterStringPref(prefs::kSSLVersionMin, std::string()); On 2015/04/28 22:38:13, eroman wrote: > unrelated ...
5 years, 7 months ago (2015-04-28 22:40:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111043002/1
5 years, 7 months ago (2015-04-28 22:45:07 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 01:14:45 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 01:15:39 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b20dfab70d330734ef1681b923b076f3bb766904
Cr-Commit-Position: refs/heads/master@{#327408}

Powered by Google App Engine
This is Rietveld 408576698