Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1111013002: Remove useless SkASSERT in SkRect.h and SkRegion.h (Closed)

Created:
5 years, 7 months ago by dshwang
Modified:
5 years, 7 months ago
Reviewers:
bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove useless SkASSERT in SkRect.h and SkRegion.h The pointer of reference is always not-null. It causes >50k lines of warnning when chromium is compiled by clang. Warning looks like ../../third_party/skia/include/core/SkRect.h:284:19: warning: reference cannot be bound to dereferenced null pointer in well-defined C++ code; pointer may be assumed to always convert to true [-Wundefined-bool-conversion] do { if (&r) break; SkNO_RETURN_HINT(); SkDebugf_FileLine("../../third_party/skia/include/core/SkRect.h", 284, false, "%s:%d: failed assertion \"%s\"\n", "../../third_party/skia/include/core/SkRect.h", 284, "&r"); SkDebugf_FileLine("../../third_party/skia/include/core/SkRect.h", 284, true, "SK_CRASH"); } while (false); Committed: https://skia.googlesource.com/skia/+/79612de00f66408cff253605fbe2bb2a9e2b27ff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M include/core/SkRect.h View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkRegion.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
dshwang
reed, bsalomon: could you review this simple CL?
5 years, 7 months ago (2015-04-28 17:50:54 UTC) #2
bsalomon
lgtm
5 years, 7 months ago (2015-04-28 19:27:58 UTC) #3
reed1
lgtm
5 years, 7 months ago (2015-04-28 19:40:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111013002/1
5 years, 7 months ago (2015-04-28 19:40:15 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 19:47:53 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/79612de00f66408cff253605fbe2bb2a9e2b27ff

Powered by Google App Engine
This is Rietveld 408576698