Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1111003002: MIPS: Fix 'Add HArrayBufferNotNeutered instruction'. (Closed)

Created:
5 years, 7 months ago by balazs.kilvady
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix 'Add HArrayBufferNotNeutered instruction'. BUG= Committed: https://crrev.com/29bee1604f93341e9f0a564a16a8fc74546a9aa4 Cr-Commit-Position: refs/heads/master@{#28117}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/mips/lithium-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
balazs.kilvady
5 years, 7 months ago (2015-04-28 16:54:05 UTC) #2
paul.l...
LGTM.
5 years, 7 months ago (2015-04-28 16:56:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1111003002/1
5 years, 7 months ago (2015-04-28 16:58:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-28 17:20:54 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/29bee1604f93341e9f0a564a16a8fc74546a9aa4 Cr-Commit-Position: refs/heads/master@{#28117}
5 years, 7 months ago (2015-04-28 17:21:10 UTC) #7
MTBrandyberry
On 2015/04/28 16:56:18, paul.l... wrote: > LGTM. I think you actually want lw when accessing ...
5 years, 7 months ago (2015-04-28 19:22:56 UTC) #8
paul.l...
5 years, 7 months ago (2015-04-28 20:16:09 UTC) #9
Message was sent while issue was closed.
On 2015/04/28 19:22:56, mtbrandyberry wrote:
> I think you actually want lw when accessing JSArrayBuffer::kBitFieldOffset. 
> Although it's really only important for big-endian mips64 (not sure if this is
> supported).

You're correct Matt, thanks for the comment! We don't support mips64 big-endian,
so I've not been looking at these closely, assuming that accesses should match
their allocation size. What I missed here is that even though the bit-field is
allocated 8-bytes on 64-bit platforms, the C++ accessors are using 32-bit
load/store. So we should do the same.

Powered by Google App Engine
This is Rietveld 408576698